22 Commits

Author SHA1 Message Date
ced
5ceedcb11e feat(@schematics/angular): remove deprecated CanLoad option for guards
Angular v15.1 deprecated the `CanLoad` guard in favor of `CanMatch`.
This commit removes the support for `CanLoad` when generating a guard with the CLI, to encourage developers to use `CanMatch` instead.

BREAKING CHANGE:
The CLI no longer allows to generate `CanLoad` guards. Use `CanMatch` instead.
2023-02-15 21:03:02 +00:00
Alan Agius
7db433bb06 fix(@schematics/angular): provide actionable error message when routing declaration cannot be found
Due to incorrect castings previously the code would crash when the module doesn't contain an routing module with the following error:

```
Cannot read property 'properties' of undefined
```

Closes #21397
2022-04-04 10:03:40 -04:00
Charles Lyding
c1512e4274 build: update files to be eslint compliant
All TypeScript files have been updated to pass the new eslint-based linting checks. eslint compatible disabling comments have also been added in place of the previous tslint comments.
2021-05-03 07:31:02 -04:00
Charles Lyding
37a06a7c37 build: format all files
All files are now formatted using the ng-dev tools via prettier.
2021-04-28 16:05:49 -07:00
Joey Perrott
003854257c build: migrate all file header to use Google LLC rather than Google Inc 2021-04-27 08:35:22 +02:00
George Kalpakas
fb14945c02 fix(@schematics/angular): correctly handle adding multi-line strings to @NgModule metadata
Previously, `addSymbolToNgModuleMetadata()` assumed that the added
symbol would not span multiple lines. In most cases, the added symbol is
a single word, so this assumption was correct. In some cases, however,
we might want to add a mutli-line string, such as a static method of an
`@NgModule`:

```ts
  imports: [
    SomeModule.staticMethod({
      prop1: 'val1',
      prop2: 'val2'
    })
  ]
```

This commit allows `addSymbolToNgModuleMetadata()` to correctly handle
multi-line strings by ensuring that added metadata symbols are always
put on a new line (even if the array is empty) and each line in the
string is indented as necessary.
2021-03-30 14:33:19 -06:00
Alan Agius
65dac11c20 fix(@schematics/angular): correctly handle PropertyAssignments with StringLiteral keys
Closes #16009
2021-01-06 12:02:06 +00:00
jaroslawsawicki
8d7703e7b5 fix(@schematics/angular): test findNodes with recursive flag
This change adds unit tests for using `recursive` flag in `findNodes`
2020-10-06 11:10:14 -04:00
timdeschryver
3784859d13 fix(@schematics/angular): add new route before wildcard route 2019-11-18 10:55:19 -08:00
Alan Agius
ae0f790ee7 fix(@schematics/angular): change findNodes to stop recursive lookup for child nodes of kind
Curtrently, when a node of kind is found, we recursivly continue to look up it's child nodes until the end of the AST. This ends up returing other nodes which we were not looking for as typically we are looking for the first level of children of the specified kind.

By default now, we stop recursivly looking for child nodes of kind when we encounter one.

Closes #15117
2019-07-24 19:06:47 -07:00
Alan Agius
15ef15e94a style: remove redundant max-line-length disables and fix other lint issues 2019-07-24 19:06:21 -07:00
Alan
2c71af1465 fix(@schematics/angular): ignore nested arrays in route declarations
`findNodes` will continue looking for arrays recursively unless we specify that we specify that we want only the first array.

Routes array can contain nested arrays such as when specifying guards.

Fixes #15016
2019-07-10 04:18:23 +08:00
hawkgs
fdcd1f7546 feat(@schematics/angular): lazy routing module generator
Introduces the lazy routing module generator as part of the existing
module generator.

Feature document:
https://docs.google.com/document/d/1NAJEWTG54cu4kW7XBp0gVadmz-gqJouW2XDs4c9PPJM/edit#heading=h.xgjl2srtytjt
2019-06-26 11:15:58 -07:00
Alan
22d77285e1 fix(@schematics/angular): handle newline after @ of a decorator
Fixes #14490
2019-05-23 19:14:58 +02:00
hawkgs
94ca819656 fix(@schematics/angular): linting errors in AST utils spec 2019-05-09 10:06:09 -07:00
hawkgs
86f1884e65 test(@schematics/angular): insert after last occurrence util 2019-05-09 10:06:09 -07:00
Alex Eagle
bf1c069f73 refactor(@schematics/angular): drop dependency on TypeScript package
instead, vendor in the two files we actually need.
This reduces our install footprint by 5MB
2019-03-06 11:27:48 -08:00
赵正阳
822d6a0b9b fix(@schematics/angular): add providers into providers metadata but not inner Object with ut. (#13081) 2018-11-30 14:08:49 -08:00
Alan Agius
8f0d03b6c2 fix(@schematics/angular): addSymbolToNgModuleMetadata metadata without indent
At the moment, at least a single whitespace is required as otherwise the following error `Cannot read property '0' of null ` will be thrown

Fixes #12950
2018-11-14 12:42:48 -08:00
vikerman
e3f56ebc71
fix(@schematics/angular): ast utils - handle NgModule with no newlines (#12521)
Exposed in Google where the formatting is different. Check for null before using a regex match result.
2018-10-09 06:37:50 -07:00
Charles Lyding
4091df0eb5 test(@schematics/angular): use HostTree instead of VirtualTree 2018-07-03 12:52:22 -04:00
Hans Larsen
44086c60ff build: move devkit repo back to angular-cli 2018-06-05 18:50:06 -07:00