28 Commits

Author SHA1 Message Date
Alan Agius
9c57e45d4e docs: improve description for optimization, configuration and target options.
Closes #16572
Closes #17978
Closes https://github.com/angular/angular/issues/39780
2020-11-25 09:09:00 +00:00
Alan Agius
f7f6eede23 fix(@angular-devkit/build-angular): disable dev-server live-reload when using protoactor
LIve-reload is not needed when using protoactor because watch mode is always disabled.
2020-10-16 21:08:18 +02:00
Alan Agius
5395cecf59 refactor: remove deprecate protractor elementExplorer
Protractor `elementExplorer` debugger and element explorer cannot be used for Node.js 8+ since it relied on `_debugger` module.

In protractor version 5, this resulted in the below error:
```
** Angular Live Development Server is listening on localhost:4200, open your browser on http://localhost:4200/ **
: Compiled successfully.
[10:25:35] I/direct - Using ChromeDriver directly...
[10:25:37] I/protractor -
[10:25:37] I/protractor - ------- Element Explorer -------
[10:25:37] I/protractor - Starting WebDriver debugger in a child process. Element Explorer is still beta, please report issues at github.com/angular/protractor
[10:25:37] I/protractor -
[10:25:37] I/protractor - Type <tab> to see a list of locator strategies.
[10:25:37] I/protractor - Use the `list` helper function to find elements by strategy:
[10:25:37] I/protractor -   e.g., list(by.binding('')) gets all bindings.
[10:25:37] I/protractor -
***********************************************************
* WARNING: _debugger module not available on Node.js 8    *
* and higher.                                             *
*                                                         *
* Use 'debugger' keyword instead:                       *
* https://goo.gl/MvWqFh                                   *
***********************************************************
/Users/alanagius/cli-repos/demo-several/node_modules/protractor/built/debugger/debuggerCommons.js:14
  throw e;
  ^

Error: Cannot find module '_debugger'
Require stack:
- /Users/alanagius/cli-repos/demo-several/node_modules/protractor/built/debugger/debuggerCommons.js
- /Users/alanagius/cli-repos/demo-several/node_modules/protractor/built/debugger/clients/explorer.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:980:15)
    at Function.Module._load (internal/modules/cjs/loader.js:862:27)
    at Module.require (internal/modules/cjs/loader.js:1042:19)
    at require (internal/modules/cjs/helpers.js:77:18)
    at Object.<anonymous> (/Users/alanagius/cli-repos/demo-several/node_modules/protractor/built/debugger/debuggerCommons.js:3:18)
    at Module._compile (internal/modules/cjs/loader.js:1156:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1176:10)
    at Module.load (internal/modules/cjs/loader.js:1000:32)
    at Function.Module._load (internal/modules/cjs/loader.js:899:14)
    at Module.require (internal/modules/cjs/loader.js:1042:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/Users/alanagius/cli-repos/demo-several/node_modules/protractor/built/debugger/debuggerCommons.js',
    '/Users/alanagius/cli-repos/demo-several/node_modules/protractor/built/debugger/clients/explorer.js'
  ]
}
```

but in protractor version 7, this logic was removed.

BREAKING CHANGE:
Protractor builder elementExplorer option has been removed. This was not compatable with the Node.Js versions that the Angular CLI supports. See: https://github.com/angular/protractor/blob/master/docs/debugging.md#enabled-control-flow for an alternative debugging methods.
2020-05-15 14:44:45 +01:00
Filipe Silva
ef7a07050a test(@angular-devkit/build-angular): build and test with Bazel 2020-04-30 15:12:46 -07:00
Jonathan Garvey
d6c9693952 feat(@angular-devkit/build-angular): pass "grep" and "invertGrep"
Pass the "grep" and "invertGrep" flags through to the Angular Protractor
builder as "jasmineNodeOpts" so that individual specs within an E2E test
file can be targeted.

Fixes #13020
2020-02-18 10:53:27 -08:00
Charles Lyding
3595cee14d fix(@angular-devkit/build-angular): resolve webdriver-manager from protractor location
The webdriver-manager package is a direct dependency of protractor.  The only guaranteed method to resolve the webdriver-manager package in this case is to resolve it from a base of the protractor location.
2020-02-06 09:09:21 -08:00
Alan Agius
07801363a6 fix(@angular-devkit/build-angular): add pattern validations for browserTarget and serverTarget 2019-11-26 13:07:13 -08:00
minijus
803f636d68 feat(@angular-devkit/build-angular): export protractor builder 2019-11-04 13:22:05 -08:00
Nikita Potapenko
645b60192b fix(@angular/cli): initialize baseUrl variable
baseUrl is not provided to protractor config because it was undefined
2019-10-03 14:40:57 -07:00
Alan Agius
3fc86b7ff5 Merge pull request #15530 from alan-agius4/protractor_base_url
fix(@angular-devkit/build-angular): add trailing back slash to protr…
2019-09-10 10:07:44 -07:00
Alan Agius
058299c531 fix(@angular-devkit/build-angular): remove deprecation of baseUrl in protractor builder
Closes #13952
2019-08-30 00:15:10 +05:30
Alan Agius
cc8c3fd904 fix(@angular-devkit/build-angular): propagate protractor errors during execution 2019-05-09 10:11:56 -07:00
Charles Lyding
0b700c3c27 fix(@angular-devkit/build-angular): protractor should use dev server baseUrl 2019-05-09 10:10:33 -07:00
Alan Agius
16ce92d77a fix(@angular-devkit/build-angular): e2e does not respect dev-server host and port settings (#14165)
Fixes #14151
2019-05-07 12:32:57 -06:00
Charles Lyding
76492141d2 refactor(@angular-devkit/build-angular): cleanup architect imports 2019-04-03 16:28:16 +02:00
Charles Lyding
ba21c855c0 refactor(@angular-devkit/build-angular): cleanup stable architect API builder file names 2019-03-29 14:37:35 -07:00
Charles Lyding
dd058a2cc3 refactor(@angular-devkit/build-angular): remove experimental architect builders 2019-03-29 14:37:35 -07:00
Charles Lyding
a49d278baa feat(@angular-devkit/build-angular): implement stable architect API for protractor 2019-03-19 09:17:15 -07:00
Hans Larsen
78f5c287d8 refactor(@angular-devkit/build-angular): clean up some interfaces and schemas
Remove the manually maintained schema.d.ts from the browser builder, and use
the Schema JSON file to generate it. This had a lot of repercussions around
the whole build-angular code base and the different interfaces that were
manually kept.
2019-02-21 16:20:54 -08:00
Charles Lyding
5016843c39 style(@angular-devkit/build-angular): remove comment reference to eject 2019-02-15 15:09:11 -08:00
Alan
5415bcc6f8 refactor: deprecate protractor baseUrl option from builder
Users should use baseUrl property in the Protractor config file
2019-02-08 16:09:30 -08:00
Alan
8252f20615 fix(@angular-devkit/build-angular): error when both baseUrl and devServerTarget are used in protractor
Users cannot use both baseUrl and devServerTarget, and the later superseeds the baseUrl.

Fixes #13611
2019-02-08 16:09:30 -08:00
Alan Agius
6db7038c1b feat(@angular-devkit/build-angular): add support for port 0 when using protractor
Fixes #13129
2019-01-08 13:42:45 -08:00
Filipe Silva
3b52fa43d3 fix(@angular-devkit/build-angular): resolve project root for fork process
Fix https://github.com/angular/angular-cli/issues/13113
2018-12-26 12:32:49 -08:00
Alan Agius
150dd4755b fix(@schematics/angular): codeCoverage exclude is not being migrated (#12511)
Fixes #10936
2018-10-10 12:09:32 -07:00
Filipe Silva
023a67254e fix(@angular-devkit/build-angular): don't override missing options in protractor (#12507)
Fix #10697
2018-10-10 12:09:02 -07:00
Alan Agius
3108ce30ab refactor: remove redundant error in catch 2018-07-02 08:20:59 -04:00
Hans Larsen
44086c60ff build: move devkit repo back to angular-cli 2018-06-05 18:50:06 -07:00