3084 Commits

Author SHA1 Message Date
Charles Lyding
a03b83c549 fix(@angular-devkit/build-angular): process nested tailwind usage in application builder
When using the application builder with Tailwind directives not in a directly referenced
Sass stylesheet, the Tailwind process was previously skipped. To avoid this problem, the
Tailwind keyword checks are now performed on the result of any stylesheet language processing
which will contain all the used stylesheet content.
2023-10-18 16:34:04 +02:00
Angular Robot
8bf90a0f16 build: update all non-major dependencies to v0.19.5 2023-10-17 08:37:31 -07:00
Charles Lyding
1ed3a16bd4 fix(@angular-devkit/build-angular): fully track Web Worker file changes in watch mode
When using the application builder with a Web Worker in watch mode, A change to the
Web Worker code will now invalidate the referencing source file to ensure that all changes
are captured and the new output file for the Web Worker is correctly injected into the
referencing output file. Previously, the Web Worker output file may have changed but the
reference may not have been updated causing an old instance of the Web worker code to be
used in watch mode.
2023-10-17 08:36:54 -07:00
Charles Lyding
8d1d3531d0 fix(@angular-devkit/build-angular): use incremental component style bundling only in watch mode
Component style bundling when using the application builder will now only generate incremental contexts
when in watch mode. During non-watch build, this incremental context information is not needed and
unnecessarily increases memory usage during a build.
2023-10-17 08:36:33 -07:00
Angular Robot
8a47ddbd24 build: update all non-major dependencies 2023-10-16 12:16:58 -07:00
Alan Agius
0f45e21189 fix(@angular-devkit/build-angular): resolve and load sourcemaps during prerendering to provide better stacktraces
With this commit when running a build with sourcemaps enabled we enable Node.js Sourcemap support for stack traces.
See: https://nodejs.org/dist/latest/docs/api/cli.html#--enable-source-maps for more information about this feature.

Before
```
ERROR ReferenceError: window is not defined
    at new _AppComponent (file:///chunk-HFZN2HE2.mjs:41631:19)
    at NodeInjectorFactory.AppComponent_Factory [as factory] (file:///chunk-HFZN2HE2.mjs:41635:12)
    at getNodeInjectable (file:///chunk-HFZN2HE2.mjs:6104:38)
    at createRootComponent (file:///chunk-HFZN2HE2.mjs:10446:31)
    at ComponentFactory.create (file:///chunk-HFZN2HE2.mjs:10348:19)
    at _ApplicationRef.bootstrap (file:///chunk-HFZN2HE2.mjs:13247:40)
    at file:///chunk-HFZN2HE2.mjs:12938:20
    at _ZoneDelegate.invoke (file:///chunk-HFZN2HE2.mjs:320:158)
    at Object.onInvoke (file:///chunk-HFZN2HE2.mjs:8562:25)
    at _ZoneDelegate.invoke (file:///chunk-HFZN2HE2.mjs:320:46)
```

Now
```
ERROR ReferenceError: window is not defined
    at constructor (/usr/xxxx/src/app/app.component.ts:16:17)
    at NodeInjectorFactory.AppComponent_Factory (/usr/xxxx/src/app/app.component.ts:17:3)
    at getNodeInjectable (/usr/xxxx/node_modules/@angular/core/fesm2022/core.mjs:4166:38)
    at createRootComponent (/usr/xxxx/node_modules/@angular/core/fesm2022/core.mjs:14064:31)
    at ComponentFactory.create (/usr/xxxx/node_modules/@angular/core/fesm2022/core.mjs:13931:19)
    at _ApplicationRef.bootstrap (/usr/xxxx/node_modules/@angular/core/fesm2022/core.mjs:30650:40)
    at <anonymous> (/usr/xxxx/node_modules/@angular/core/fesm2022/core.mjs:30163:20)
    at _ZoneDelegate.invoke (/usr/xxxx/node_modules/zone.js/fesm2015/zone-node.js:344:158)
    at Object.onInvoke (/usr/xxxx/node_modules/@angular/core/fesm2022/core.mjs:10964:25)
    at _ZoneDelegate.invoke (/usr/xxxx/node_modules/zone.js/fesm2015/zone-node.js:344:46)
```

Closes #26013
2023-10-16 08:37:29 +02:00
Charles Lyding
a136f2ec58 fix(@angular-devkit/build-angular): ensure i18n locale data is included in SSR application builds
When using the application builder to create server builds for SSR and/or prerendering with localization
enabled, the locale data for each enabled locale is now properly included in the server output files.
While browser builds contain this data in the polyfills output file, the server builds do not contain a
polyfill output file, as a result, the locale data is added to the main server code instead. This is also
the case for other polyfill-like code including zone.js.
2023-10-16 08:36:44 +02:00
Angular Robot
401be269f9 build: update dependency magic-string to v0.30.5 2023-10-13 10:46:11 +02:00
Charles Lyding
6ec14323a3 refactor(@angular-devkit/build-angular): bundle polyfills independent of main code in application builder
Any provided or required polyfills (the later mainly related to i18n) will now be bundled in a separate
concurrent bundling action. This has several benefits including allowing different bundling options
for the polyfills and minimizing rebundling of polyfills (which rarely change) in watch/serve mode.
Along with this change, the polyfill bundling options have been adjusted to not externalize packages
when in development server mode. This allows the zone.js globals to be more easily used as well as
minimizing the need for Vite to process a typically unchanging output file.
2023-10-13 10:45:59 +02:00
Alan Agius
9ad99c1c70 fix(@angular-devkit/build-angular): do not print Angular is running in development mode. in the server console when running prerender in dev mode
Prior to this change `Angular is running in development mode` was printed multiple times when running prerendering in devmode.
2023-10-13 07:26:46 +02:00
Alan Agius
3f679f165b fix(@angular-devkit/build-angular): do not print Angular is running in development mode. in the server console when running prerender in dev mode
Prior to this change `Angular is running in development mode` was printed multiple times when running prerendering in devmode.
2023-10-13 07:26:46 +02:00
Alan Agius
b2678bb792 fix(@angular-devkit/build-angular): several fixes to assets and files writes in browser-esbuild builder
This commit ports https://github.com/angular/angular-cli/pull/26016 to the esbuilder and also fixes an issue where assets were being outputted in the wrong directory.

Closes #26021
2023-10-12 15:57:44 +02:00
Angular Robot
ec335e8849 build: update all non-major dependencies to v7.23.2 2023-10-12 08:56:23 +02:00
Alan Agius
1830fa3b9a refactor: add warning when using browser-esbuild
This commits add a warning when using the browser-esbuild builder which eventually will be removed in favor of the `application` builder.
2023-10-12 08:32:22 +02:00
Charles Lyding
0da87bf1c9 fix(@angular-devkit/build-angular): limit concurrent output file writes with application builder
When using localization with the application builder for a large amount of locales, the number
of files that may need to be written to disk can become large. This may be problematic on certain
operating systems depending on the open file process limits. To avoid approaching the limit, the
number of concurrent writes is now limited to 64.
2023-10-12 07:43:08 +02:00
Alan Agius
6d481c8d88 refactor(@angular-devkit/build-angular): move common steps in a shared function
With this change common steps that are executed when running an i18n build and not are moved into a shared file.
2023-10-12 07:30:16 +02:00
Charles Lyding
ac7caa4264 fix(@angular-devkit/build-angular): ensure unique internal identifiers for inline stylesheet bundling
Within the application builder's template stylesheet processing, internal identifiers are used to track
the incremental bundling status of each inline stylesheet. This identifier now consists of the stylesheet
language, data, and containing file. This ensures that a tracking entry is maintained for each inline
stylesheet and allows for the full cleanup and any incremental bundling resources at the end of the build.
2023-10-11 21:16:22 +02:00
Charles Lyding
c12f98f948 fix(@angular-devkit/build-angular): conditionally enable deprecated Less stylesheet JavaScript support
When a Less stylesheet is detected to require the deprecated `javascriptEnabled` Less option, the option
is enabled for the stylesheet and a warning is issued to inform the user of the behavior change. The
Less `javascriptEnabled` option has been deprecated and disabled by default since Less v3 (https://github.com/less/less.js/releases/tag/v3.0.0).
When enabled, the `javascriptEnabled` option allows JavaScript within Less stylesheets to be executed at build time.

Less option reference: https://lesscss.org/usage/#less-options

This provides similar behavior to the default Webpack-based build system. However, the Webpack-based build system
currently unconditionally enables the option.
2023-10-11 19:53:39 +02:00
Charles Lyding
c74e618429 refactor(@angular-devkit/build-angular): export application builder for experimental programmatic usage
Similar to the existing Webpack-based `browser` builder, the new `application` builder is also exported
from the `@angular-devkit/build-angular` package for use programmatically. As is the case for the existing
builder JavaScript exports from the package, the new export (`buildApplication`) is also considered experimental
and does not provide the support nor semver guarantees that the builders have when used via `angular.json` configuration.
The usage of the `plugins` parameter of the `buildApplication` allows adding esbuild compatible plugins to the end
of the plugin list for the main application code bundling. However, usage of the parameter may result in unexpected application
output and/or build failures. Stable and supported methods for build process extension are being evaluated for a future release.
2023-10-11 19:52:26 +02:00
Alan Agius
f1cf952485 docs(@angular/cli): remove incorrect statement about outputPath
By default output path does not default to dist.
2023-10-11 19:52:03 +02:00
Doug Parker
e5849c8995 refactor: strengthen language around Protractor support status
Protractor is no longer deprecated, it's already end-of-life. I didn't commit to a specific version because plans always fluctuate, but it is eligible to be removed in any future Angular major version.
2023-10-11 13:10:56 +02:00
Alan Agius
c48982dc1d feat(@angular-devkit/build-angular): add buildTarget option to dev-server and extract-i18n builders
This is to better match the nature of the application builder where the target can be both browser and server.

DEPRECATED: The `browserTarget` in the dev-server and extract-i18n builders have been deprecated in favor of `buildTarget`.
2023-10-10 19:43:11 +02:00
Charles Lyding
771e036d5c feat(@angular-devkit/build-angular): support deploy URL option for browser-esbuild builder
The `browser-esbuild` builder now provides support for using the `deployUrl` option when building
applications.  This option is still considered deprecated which is the same status as with the
Webpack-based `browser` application builder. This option is only available with the `browser-esbuild`
builder and not other esbuild-based builders. The `browser-esbuild` builder is primarily intended
to be used as a compatibility builder with the `browser` builder that requires only minimal changes
to use.
2023-10-10 16:28:43 +02:00
Alan Agius
8d0b707a79
refactor(@angular-devkit/build-angular): update ESM in memory file loader to work with Node.js 20 (#25988)
This commit refactors the ESM Node.js in memory loader to work with Node.js 20+
2023-10-09 19:41:59 +02:00
Charles Lyding
3ad028bb44 fix(@angular-devkit/build-angular): ensure localize polyfill and locale specifier are injected when not inlining
When using the esbuild-based builders (`application`/`browser-esbuild`), the localize polyfill and the locale specifier
for the configured source locale will now be injected into the application when available and the application is not
configured to inline translations (`localize` option disabled or otherwise not used). This is useful for when developing
a localized application with the development server or when the application is not translated but has a customized source
locale.
2023-10-09 19:40:14 +02:00
Charles Lyding
2c33f09db0 fix(@angular-devkit/build-angular): avoid dev-server proxy rewrite normalization when invalid value
When normalizing the proxy configuration for the Vite-based development server, the `pathRewrite` logic
will now be skipped if the proxy entry is not an object and therefore invalid. This situation can occur
if the proxy configuration JSON contains invalid properties.

Closes #25978
2023-10-09 19:39:56 +02:00
Alan Agius
8981d8c355 fix(@angular-devkit/build-angular): improve sharing of TypeScript compilation state between various esbuild instances during rebuilds
This commit improves the logic to block and share a TypeScript results across multiple esbuild instances (browser and server builds) which fixes an issue that previously during rebuilds in some cases did not block the build correctly.
2023-10-09 16:40:36 +02:00
Alan Agius
99d9037eee perf(@angular-devkit/build-angular): only perform a server build when either prerendering, app-shell or ssr is enabled
Prior to this change, a server build was performed when all the "server" features were disabled but the `server` fields was specified.
2023-10-09 15:55:27 +02:00
Alan Agius
968ee34280 fix(@angular-devkit/build-angular): fully downlevel async/await when using vite dev-server with caching enabled
Prior to this change, async/await in external packages were not being correctly downlevelled when using vite dev-server with cache enabled.

Closes #25985
2023-10-09 15:55:09 +02:00
Charles Lyding
91019bde2a feat(@angular-devkit/build-angular): enable localize support for SSR with application builder
With the output path directory structure updates in place, the localize support for SSR has
now been enabled. This allows for the `application` builder to produce both browser and server
output that is localized based on the i18n configuration for the project.
2023-10-09 10:34:09 +02:00
Charles Lyding
223a82f5f0 perf(@angular-devkit/build-angular): use incremental bundling for component styles in esbuild builders
When using the esbuild-based builders (`esbuild-browser`/`application`) in watch mode (including `ng serve`),
component stylesheets will now be incrementally rebuilt when needed. This avoids a full build of each
affected component's styles during an application rebuild. Both JIT and AOT mode are supported as well
as both inline and external styles.
2023-10-09 10:29:55 +02:00
Charles Lyding
9e425308a0 feat(@angular-devkit/build-angular): support component style budgets in esbuild builders
The `anyComponentStyle` budget type is now supported when using bundle budgets in the esbuild-
based builders (`browser-esbuild`/`application`). The configuration and behavior are intended
to match that of the Webpack-based  builder (`browser`). With this addition, the bundle budget
feature is now at feature parity with the Webpack-based builder.
The implementation of this budget type requires less code than the Webpack implementation due
to the component stylesheet information being present in the application's output metadata. This
removes the need for a custom budget plugin to extract the stylesheet size information during the build.
2023-10-09 10:17:35 +02:00
Angular Robot
c9208027b1 build: update all non-major dependencies 2023-10-09 10:17:27 +02:00
Charles Lyding
1fb0350eb7 feat(@angular-devkit/build-angular): add initial support for bundle budgets to esbuild builders
The bundle budget functionality (`budgets` option) is not available when using the esbuild-based
builders (`browser-esbuild`/`application`). The existing option format from the Webpack-based builder can
continue to be used. All budget types except `anyComponentStyle` are implemented. Any usage of the
`anyComponentStyle` type will be ignored when calculating budget failures. This type will be implemented
in a future change.
2023-10-06 14:49:38 -04:00
Alan Agius
1541cfd6b8 refactor(@angular-devkit/build-angular): move SourceFileCache into dedicated file
This is to reduce the code in `compiler-plugin.ts`
2023-10-06 19:51:27 +02:00
Charles Lyding
1f73bcc49a fix(@angular-devkit/build-angular): ensure Web Worker code file is replaced in esbuild builders
The previous Web Worker bundling code for the esbuild-based builders assumed that the first
output file was the JavaScript code for the worker. While this is typically the case, when
sourcemaps are enabled it may not be. To ensure the code file is used as the replacement path
for the Worker constructor, the output files are now searched for the code file.
2023-10-05 15:35:34 -04:00
Alan Agius
c98c049b6e test: update tests to account for changes in the build output structure
This commit updates the tests to account for the new build structure.
2023-10-05 13:30:52 -04:00
Alan Agius
49f07a84d6 feat(@angular-devkit/build-angular): standardize application builder output structure
This commit updates the application builder to output files in a standardized manner. The builder will output a `browser` directory for all the files that can be accessible by the browser, and a `server` directory that contains the SSR application. Both of these directories are created as children in the configured `outputPath`. Stats and license files will be outputted directly in the configured `outputPath`.

Example of output:
```
3rdpartylicenses.txt
├── browser
│   ├── chunk-2XJVAMHT.js
│   ├── favicon.ico
│   ├── index.html
│   ├── main-6JLMM7WW.js
│   ├── polyfills-4UVFGIFL.js
│   └── styles-5INURTSO.css
└── server
    ├── chunk-4ZCEIHD4.mjs
    ├── chunk-PMR7BAU4.mjs
    ├── chunk-TSP6W7K5.mjs
    ├── index.server.html
    ├── main.server.mjs
    └── server.mjs
```
2023-10-05 13:30:52 -04:00
Alan Agius
f29b744d4e refactor(@angular-devkit/build-angular): remove hardcoded Node.js version in application builder
This commit removed the hard coded Node.js version in application builder server config and instead passes the Angular CLI supported Node.js versions that are currently stamped using Bazel.
2023-10-05 17:28:48 +02:00
Alan Agius
667f43af6d fix(@angular-devkit/build-angular): correctly resolve polyfills when baseUrl URL is not set to root
Prior to this change when `baseUrl` was set to non-root or not set polyfills were not correctly resolved. Internally Esbuild uses the `baseUrl` to resolve non relative imports.

Closes: #25341
2023-10-05 10:00:05 -04:00
Angular Robot
3f2e2d3f9e build: update all non-major dependencies 2023-10-04 14:46:08 -04:00
cexbrayat
5898f72a97 feat(@angular-devkit/build-angular): support namedChunks option in application builder
This adds the support of `namedChunks` for the new `application` builder.
It generates output like the following:

```
Initial Chunk Files         | Names         |  Raw Size | Estimated Transfer Size
chunk-ACXUMF56.js           | -             |  94.14 kB |                28.25 kB
main-3WP5KDHR.js            | main          |  71.95 kB |                18.31 kB
polyfills-4UVFGIFL.js       | polyfills     |  32.85 kB |                10.68 kB
chunk-2XJVAMHT.js           | -             | 449 bytes |               449 bytes
styles-5INURTSO.css         | styles        |   0 bytes |                 0 bytes

                            | Initial Total | 199.38 kB |                57.68 kB

Lazy Chunk Files            | Names         |  Raw Size | Estimated Transfer Size
about.component-2PJOS5PM.js | -             | 401 bytes |               401 bytes
home.component-25UHFOEY.js  | -             | 398 bytes |               398 bytes
```

This is really handy to get a glimpse at what a chunk is referring to and be able to analyze it (especially in applications with dozens of chunks).
2023-10-04 11:21:54 -04:00
Angular Robot
76da08478f build: update dependency postcss to v8.4.31 [security] 2023-10-04 11:03:41 -04:00
Charles Lyding
fd62a9315d feat(@angular-devkit/build-angular): support i18n with service worker and app-shell with esbuild builders
When using the esbuild-based application build system through the `application` builder, the `localize`
option will now allow inlining project defined localizations when using the app shell, prerendering,
and service worker features. Previously a warning was issued and these features were disabled when the
`localize` option was enabled.
2023-10-04 09:53:45 -04:00
Charles Lyding
83020fc329 fix(@angular-devkit/build-angular): clear diagnostic cache when external templates change with esbuild builders
To prevent stale Angular template diagnostics from persisting in watch mode (including `ng serve`), the template
diagnostic cache will now be invalidated based on the set of changed external template files. This ensures that
the Angular AOT compiler will analyze the template again during the rebuild and clear any fixed errors.
2023-10-04 09:50:06 -04:00
Charles Lyding
9c4a6be2d1 refactor(@angular-devkit/build-angular): improve accuracy of programmatic watch mode usage for esbuild builders
To better capture file changes after the initial build for the esbuild-based builders in a programmatic usage,
the file watching initialization has been moved to before the first build results are yielded. This allows tests
that execute code to change files with improved accuracy of the watch mode triggering. The application builder
now also supports aborting the watch mode programmatically. This allows tests to gracefully stop the watch mode
and more fully cleanup the test at completion.
2023-10-04 09:49:50 -04:00
Alan Agius
2d2e79921a fix(@angular-devkit/build-angular): clean up internal Angular state during rendering SSR
This commit clean ups the compiled components state when the build is being executed in watch mode. This is required as otherwise during development `Component ID generation collision detected` are displayed on the server.

Closes: #25924
2023-09-29 18:47:39 +02:00
Alan Agius
1837fee197 refactor(@angular-devkit/build-angular): use whenStable private API in route extractor
This commit refactors the route extractor to use the newly `whenStable` API.
2023-09-28 17:31:51 +02:00
Alan Agius
26456b93d5 fix(@angular-devkit/build-angular): do not print Angular is running in development mode. in the server console when using dev-server
This commit disables logging `Angular is running in development mode.` when using SSR with vite dev-server. This to avoid polluting the server console with `Angular is running in development mode.` logs for each page load and reload.

Example:
```
ng s

Initial Chunk Files | Names         | Raw Size
main.js             | main          | 34.31 kB |
polyfills.js        | polyfills     | 95 bytes |
styles.css          | styles        | 95 bytes |

                    | Initial Total | 34.49 kB

Application bundle generation complete. [5.205 seconds]

  ➜  Local:   http://localhost:4200/
Watch mode enabled. Watching for file changes...
Angular is running in development mode.
Angular is running in development mode.
Angular is running in development mode.
Angular is running in development mode.
Angular is running in development mode.
Angular is running in development mode.
```
2023-09-27 18:58:31 +02:00
Alan Agius
6b5c469a42 build: update all non-major dependencies 2023-09-27 14:08:41 +02:00