112 Commits

Author SHA1 Message Date
Sachin Grover
8543bf7f8c fix(@schematics/angular): scroll issue on new app after adding Material
Fixes #16966
2020-02-18 12:49:59 -08:00
Christoph Guttandin
cd4822393b fix(@schematics/angular): set inlineTemplate and inlineStyle for minimal projects 2020-02-18 12:47:09 -08:00
Alan Agius
2335c1f3bf fix(@schematics/angular) remove file extension from zone flags comment 2020-02-12 12:01:08 -08:00
Cyrille Tuzi
ee589d9116 fix(@schematics/angular): add compliance with no-any lint rule 2020-01-29 10:19:36 -08:00
cexbrayat
3ec4f61357 fix(@schematics/angular): remove unneeded debugElement in test
The generate tests in `app.component.spec.ts` are using `fixture.debugElement.componentInstance` whereas we can directly use `fixture.componentInstance`. This fixes the generated test to show a better example to users discovering unit tests.
2019-10-21 09:38:16 -07:00
Muhammad Umair Khan
bcbbc19293 fix(@schematics/angular): scroll issue on new app (#15714)
Subtracting the top space from image vh(viewport height) to remove scroll

Closes #15596
2019-10-07 09:15:08 -07:00
FG-33
9de282ca32 feat(@schematics/angular): add generator for interceptor
Rework.
2019-09-26 09:58:00 -07:00
Elvis Begovic
b2e74d119c feat(@schematics/angular): minimal=true should not create tests files when using ng generate command
Before this commit:
`--minimal=true` create project without any testing frameworks and disable e2e, lint, test targets.
But, if in this minimal project we try command `ng generate class|component|directive|guard|module|pipe|service`, it will always create `*_spec.ts` files.

After this commit:
`--minimal=true` override `@schematics/angular` in `angular.json` to not create `*_spec.ts` files when using `ng generate *` commands.
2019-09-09 14:10:50 -07:00
Christian Liebel
8527206d6e feat(@schematics/angular): feature PWA in CLI app
Feature PWA support via `@angular/pwa` directly in the new CLI app.
2019-09-04 02:30:15 +05:30
Alan Agius
8866f1d964 refactor(@schematics/angular): remove redundant aot option for production 2019-08-30 00:08:52 +05:30
Alan Agius
a35d9084ce refactor(@schematics/angular): remove classes from twitter icon as it breaks Ivy in IE11
https://github.com/angular/angular/issues/32192
2019-08-28 22:54:52 +05:30
vikerman
860d5925e6 fix(@schematics/angular): open twitter link in new tab (#15446)
Change the default application to open the twitter link in a new tab
instead of in the current tab. This is consistent with all the other
external links in the page.
2019-08-26 11:49:35 -07:00
Stefanie Fluin
a05148e9f5 fix(@schematics/angular): add twitter link icon (#15385)
* fix(@schematics/angular): add twitter link icon

* fix(@schematics/angular): remove height unit
2019-08-21 10:34:00 -07:00
Alan
ba8a6ea599 feat(@schematics/angular): remove enableIvy option
With this change we remove the enableIvy option as now we only support generating Ivy application. Users who want to create a VE applications should follow the opt-out guide
2019-08-16 09:31:02 -07:00
Minko Gechev
26f66fe366
fix(@schematics/angular): handle the inlineTemplate case for ng new (#15324)
Update the template of `app.component.ts` when using `--inlineTemplate`.
2019-08-14 10:22:09 -07:00
Stefanie Fluin
40601c46e7 feat(@schematics/angular): cli app redesign (#14403)
* feat(@angular/cli): cli app redesign

* add template comment code and fix rocket ship smoke image placement

* correct tests verbiage

* fix tests copy of PR 14484

* move styles to template and remove unused icons font ref

* move font references to template

* remove external font references

* remove body styles and simplify css

* add comment block and remove old comments

* fix end of placeholder comment
2019-08-12 13:54:09 -07:00
Charles Lyding
5a7b823b28 test: remove use of deprecated synchronous test helper runSchematic 2019-08-08 08:27:31 -07:00
Alan Agius
d7b9650b5f refactor(@schematics/angular): remove hardcoded default values
Defaults in code are no longer required as the root issue was solved by https://github.com/angular/angular-cli/pull/15222
2019-08-08 08:25:50 -07:00
Amadou Sall
c4a3262ee2 fix(@schematics/angular): the ng-new schematic should not prompt for style
closes #13383
2019-08-02 13:34:26 -07:00
Amadou Sall
a9ac221c40 fix(@schematics/angular): application schematic should prompt for --routing and --style
This is the first step towards solving issue related to #13383

closes #14705
2019-07-29 10:44:48 -07:00
vikerman
07780b9272 style: clean up existing lint errors 2019-07-24 23:28:49 -07:00
Alan Agius
15ef15e94a style: remove redundant max-line-length disables and fix other lint issues 2019-07-24 19:06:21 -07:00
Alan Agius
2a0dc39de3 feat(@schematics/angular): add anyComponentStyle to the applications bundle budget 2019-07-24 19:05:00 -07:00
Amadou Sall
d25879f9fc fix(@schematics/angular): the required 'alt' attribute is missing in the root component's template
When you generate an application with `--minimal` flag, the image in the
HTML template of the root component doesn't have the 'alt' attribute
2019-07-24 19:02:47 -07:00
Alan Agius
0551360035 fix(@schematics/angular): exclusively list the files in tsconfigs (#15030)
* test: update tests to work with new stricter tsconfig file inclusions

* fix(@schematics/angular): exclusively list the files in tsconfigs

With the omission of `includes` or `files` in tsconfig files tsc will pick up all the files under the rootDir and make them as part of the compilation. In certain cases, redundant files will be picked up which will cause a slower compilations.

Related to: TOOL-949
2019-07-16 11:04:29 -07:00
Cédric Exbrayat
9d4d5742bb feat(@schematics/angular): enable ivy in tests (#15044)
If a project is generated with `enableIvy`, this commit adds the necessary configuration to `tsconfig.spec.json` to then run the tests with Ivy. Note that the CLI already does the correct work (runs `ngcc` and then runs the tests).
2019-07-15 09:50:16 -07:00
Alan Agius
fce849c7d6 fix(@schematics/angular): remove lint target from minimal projects
Minimal projects are considered as throw-away projects and only a small subset of features are supported.

More context #13408 and #13354

Closes #14727
2019-06-11 09:56:42 -07:00
Filipe Silva
24f37a602c feat(@schematics/angular): default Ivy apps to AOT true
Testing on AIO with Angular master as of 28/05/2019 I got these results:
JIT ~414ms (369, 378, 408, 323, 593)
AOT using VE ~1383ms (1365, 1185, 1767, 1135, 1467)
AOT using Ivy ~517ms (600, 391, 444, 756, 394)

This is largely due to https://github.com/angular/angular/pull/29380 and https://github.com/angular/angular/pull/30238.

The second PR above was not merged to master, and thus will not be in 8.0.0. This PR should be merged to match it.
2019-06-06 14:03:00 -07:00
Alan Agius
04b854956c fix(@schematics/angular): remove old GoogleBot browserslist setting
GoogleBot is now evergreen, we don't need to specialcase it: https://webmasters.googleblog.com/2019/05/the-new-evergreen-googlebot.html?m=1

Fixes #14364
2019-05-09 10:08:52 -07:00
Alan Agius
a464c001c3 fix(@schematics/angular): fix paths when newProjectRoot is an empty string
When `newProjectRoot` the paths are prefixed with an `/` example `/project-name/tsconfig.lib.json` which results in these being marked as absolute paths, which causes build failures.

Fixes #14108
2019-04-22 16:17:39 -07:00
Alan
f03ff807b4 refactor(@schematics/angular): create relativePathToWorkspaceRoot helper and replace usages 2019-04-19 10:55:02 -07:00
Minko Gechev
4d7581d60b feat(@schematics/angular): enable support for Chrome 41
We want apps to be SEO friendly by default.
2019-04-19 10:49:03 -07:00
Alan Agius
b976a3e72b refactor(@schematics/angular): don't add es5BrowserSupport by default 2019-04-18 11:46:25 -07:00
cexbrayat
0ce98ceeb3 docs(@schematics/angular): mention npx browserslist in browserslist
Running `npx browserslist` allows to see what browsers are actually selected with the configuration,
which is very handy and not very known.
2019-04-17 15:47:39 -07:00
Charles Lyding
58f6282edf refactor(@schematics/angular): update application to use new workspace rules 2019-04-16 11:23:48 -07:00
Alan Agius
413a35bd56 feat(@schematics/angular): add more information and browsers in browserlist 2019-04-15 11:30:34 -07:00
Alan Agius
fe98024146 docs: align several experimental text and update ng new explanation 2019-04-10 08:44:53 -07:00
Alan
3f6c1b5cd6 fix(@schematics/angular): minimal should not add test target
At the moment when using minimal flag, test targets are being created even though they cannot be used as test setup files are not created nor are testing dependencies
2019-04-04 09:28:19 -07:00
Alan Agius
f84abfc572 feat(@schematics/angular): remove ivy-ngcc postinstall script from new application 2019-04-01 02:54:41 -07:00
JiaLiPassion
888bb27815 refactor: rename Zone 'BLACK_LISTED_EVENTS' to 'UNPATCHED_EVENTS' 2019-04-01 00:48:24 -07:00
Hans Larsen
2ffbdfa86a build: add a validation script for the analytics.md tables
Also added enums to update when changing dimensions.
2019-03-28 13:28:41 -07:00
Hans Larsen
55471770db refactor: use dimensions for some values instead of metrics
This is after a discussion with someone internal. Metrics are good
for sums but not for comparisons and search/filtering.
2019-03-28 13:28:41 -07:00
Hans Larsen
2e9dc3d252 docs: add analytics dimensions for schematics flags and internal doc
The analytics.md should be kept up to date with the flags.
2019-03-20 15:08:07 -07:00
Alan
a7d095d916 feat(@schematics/angular): change layout for root applications
This change aligns the file layout of applications generated with `ng new` and `ng generate`

Ref: TOOL-686
2019-03-06 11:28:26 -08:00
Alan
08c4cb748f fix(@schematics/angular): reintroduce .sass as a supported file extention
Sass Indented (.sass) is fully supported by the Sass team and we should still offer and support it.

Fixes #13739
2019-03-04 10:26:09 -08:00
Alan Agius
9e18cf240e fix(@schematics/angular): kebab case prefix causes lint errors in new directives
`Component` selectors are always kekabed while `Directive` selectors are always camelized. This updates the lint rules to convert the prefix to the appropiate case

Fixes #13796
2019-03-04 09:35:22 -08:00
Alan
026ae8cefc feat(@schematics/angular): change layout of e2e files
With this change E2E files will be relocated inside an existing application instead of creating a seperate E2E project. This will also remove a lot of extra boilerplating inside the workspace configuration file.

File layout:
```
│   browserslist
│   karma.conf.js
│   tsconfig.app.json
│   tsconfig.spec.json
│   tslint.json
│
├───e2e
│   │   protractor.conf.js
│   │   tsconfig.e2e.json
│   │
│   └───src
│           app.e2e-spec.ts
│           app.po.ts
│
└───src
    │   favicon.ico
    │   index.html
    │   main.po.ts
    │   main.ts
    │   polyfills.ts
    │   styles.css
    │   test.ts
    │
    ├───app
    │       app.component.css
    │       app.component.html
    │       app.component.spec.ts
    │       app.component.ts
    │       app.module.ts
    │
    ├───assets
    │       .gitkeep
    │
    └───environments
            environment.prod.ts
            environment.ts
```

Ref: TOOL-699
2019-03-04 09:33:12 -08:00
Filipe Silva
05966646e7 feat(@schematics/angular): rename experimentalIvy to enableIvy
Followup to https://github.com/angular/angular/pull/28569#discussion_r259558085
2019-02-26 10:49:58 -08:00
Charles Lyding
b96e7bf76f fix(@schematics/angular): default newProjectRoot to current directory 2019-02-26 08:39:57 -08:00
cexbrayat
58bc5b8f2a fix(@schematics/angular): remove ViewEncapsulation from root component 2019-02-22 15:53:34 -08:00