* revert: fix(@ngtools/webpack): output consistent filename
This reverts commit df172bdc8af4caa1a908592a8b9400d31c81eeb0.
* refactor(@ngtools/webpack): remove RegExp for ngfactory
This RegExp is not needed as if it actually works it will break lazy loading as in case of AOT, the name should always be suffixed with ngfactory
4c2ce4e8ba/packages/core/src/linker/system_js_ng_module_factory_loader.ts (L83)
This commits adds a base href value in the karma context iframe used to run unit tests.
It solves a very old issue in Angular https://github.com/angular/angular/issues/12295 where a unit test throws:
No base href set. Please provide a value for the APP_BASE_HREF token or add a base element to the document.
even if the application is fine. This is because the `index.html` from Angular CLI contains a base href value, but not the Karma context iframe. So when adding a unit test with a testing module that imports a NgModule, for example `AppModule`, which itself imports `RouterModule`, the unit test used to throw an error (regression appeared in router 3.1).
That could be solved by either adding `RouterTestingModule` to the testing module, or by adding a provider `{ provide: APP_BASE_HREF, useValue: '/' }`, but required to understand the issue (see how many thumbs up there are on the original issue).
This solves the issue in a transparent way: developers won't even encounter the problem anymore.
* fix(@angular-devkit/core): errors and warnings are hard to read in windows cmd
Closes#12755
* fix(@angular/cli): errors and warnings are hard to read in windows cmd
Closes#12755
This commit updates the BUILD files to specify fine-grained node_module deps
by replacing "@typings" comments with actual @npm node module.
Moved tools/bazel.rc -> .bazelrc
Removed "jasmine" typings from base tsconfig.json
Added @bazel/karma to devDependencies, needed for `ts_web_test`
At the moment, only kebab case args works, and this might be misleading if you come from the Angular CLI. As for instance `--dryRun` will have no effect.
Fixes#12599
* fix(@ngtools/webpack): emit lazy routes errors on rebuilds
At the moment lazy route errors are only emitted in the initial builds because in following builds we are only processed lazy routes that are declared in the changed files.
At the moment, we cannot cache the previously resolved routes as there is no way to track in which file the lazy route was declared so that we can bust the lazy route if it was removed.
Closes#12236
* test: add test for compilation errors in watch mode
Closes#12311
At the moment when having namedChunks file names are different between JIT and AOT builds .
AOT will will output something like
```
customers-customers-module-ngfactory.9b8b989df2e32e5cadac.js
```
while JIT will output
```
customers-customers-module.js
```
This PR aligns the output file name
