Graham/angular-cli
1
0
Fork 0
mirror of https://github.com/angular/angular-cli.git synced 2025-05-16 02:24:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(@angular/build): ensure relative karma stack traces for test failures

Browse Source 
The karma configuration will now automatically set the `basePath` option
to the temporary output path when using the application build system's
karma testing. This ensures that only the relative path of the test files
is represented in the stack traces of test failures.
This commit is contained in:
Charles Lyding 2025-03-13 11:46:16 -04:00 committed by Charles
parent 18e13e2cee
commit f780e8beb3
2 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
packages/angular/build/src/builders/karma/application_builder.ts
View File

@ -438,7 +438,8 @@ async function initializeApplication(
await writeTestFiles(buildOutput.files, buildOptions.outputPath);
// We need to add this to the beginning *after* the testing framework has
// prepended its files.
// prepended its files. The output path is required for each since they are
// added later in the test process via a plugin.
const polyfillsFile: FilePattern = {
pattern: `${outputPath}/polyfills.js`,
included: true,
@ -454,12 +455,14 @@ async function initializeApplication(
watched: false,
};
karmaOptions.basePath = outputPath;
karmaOptions.files ??= [];
if (options.scripts?.length) {
// This should be more granular to support named bundles.
// However, it replicates the behavior of the Karma Webpack-based builder.
karmaOptions.files.push({
pattern: `${outputPath}/scripts.js`,
pattern: `scripts.js`,
watched: false,
type: 'js',
});
@ -467,18 +470,18 @@ async function initializeApplication(
karmaOptions.files.push(
// Serve global setup script.
{ pattern: `${outputPath}/${mainName}.js`, type: 'module', watched: false },
{ pattern: `${mainName}.js`, type: 'module', watched: false },
// Serve all source maps.
{ pattern: `${outputPath}/*.map`, included: false, watched: false },
{ pattern: `*.map`, included: false, watched: false },
// These are the test entrypoints.
{ pattern: `${outputPath}/spec-*.js`, type: 'module', watched: false },
{ pattern: `spec-*.js`, type: 'module', watched: false },
);
if (hasChunkOrWorkerFiles(buildOutput.files)) {
karmaOptions.files.push(
// Allow loading of chunk-* files but don't include them all on load.
{
pattern: `${outputPath}/{chunk,worker}-*.js`,
pattern: `{chunk,worker}-*.js`,
type: 'module',
included: false,
watched: false,
@ -488,7 +491,7 @@ async function initializeApplication(
if (options.styles?.length) {
// Serve CSS outputs on page load, these are the global styles.
karmaOptions.files.push({ pattern: `${outputPath}/*.css`, type: 'css', watched: false });
karmaOptions.files.push({ pattern: `*.css`, type: 'css', watched: false });
}
const parsedKarmaConfig: Config & ConfigOptions = await karma.config.parseConfig(

2
tests/legacy-cli/e2e/tests/test/test-sourcemap.ts
View File

@ -20,7 +20,7 @@ export default async function () {
throw new Error('ng test should have failed.');
} catch (error) {
assertIsError(error);
assert.match(error.message, /src\/app\/app\.component\.spec\.ts/);
assert.match(error.message, /\(src\/app\/app\.component\.spec\.ts:3:27/);
assert.doesNotMatch(error.message, /_karma_webpack_/);
}