Graham/angular-cli
1
0
Fork 0
mirror of https://github.com/angular/angular-cli.git synced 2025-05-16 18:43:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

ci: several fixes of PR CI runs

Browse Source 
Currently, the Renovate PRs will run the full E2E suit on WIndows because `CIRCLE_PR_NUMBER` is not defined for PRs which are opened from non forked repos. Instead we replace it with `CIRCLE_PULL_REQUEST` which is always defined.

Also, such non forked PRs will cause uploading of Bazel result in remote cache. This is now disabled.

Example runs:
https://app.circleci.com/pipelines/github/angular/angular-cli/15228/workflows/4bf31046-3317-4422-bf57-5156eef69259/jobs/245137
This commit is contained in:
Alan Agius 2021-04-29 12:12:57 +02:00 committed by Charles
parent d66a5b8e13
commit f4baa064fe
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
.circleci/config.yml
View File

@ -97,7 +97,7 @@ commands:
openssl aes-256-cbc -d -in .circleci/gcp_token -md md5 -k "${<< parameters.key >>}" -out /home/circleci/.gcp_credentials;
sudo bash -c "echo -e 'build --google_credentials=/home/circleci/.gcp_credentials' >> .bazelrc.user";
# Upload/don't upload local results to cache based on environment
if [[ -n "{$CIRCLE_PR_NUMBER}" ]]; then
if [[ -n "{$CIRCLE_PULL_REQUEST}" ]]; then
sudo bash -c "echo -e 'build:remote --remote_upload_local_results=false\n' >> .bazelrc.user";
echo "Not uploading local build results to remote cache.";
else
@ -287,7 +287,7 @@ jobs:
- run:
name: Execute E2E Tests
command: |
if (Test-Path env:CIRCLE_PR_NUMBER) {
if (Test-Path env:CIRCLE_PULL_REQUEST) {
node tests\legacy-cli\run_e2e.js "--glob={tests/basic/**,tests/i18n/extract-ivy*.ts,tests/build/profile.ts}" --nb-shards=$env:CIRCLE_NODE_TOTAL --shard=$env:CIRCLE_NODE_INDEX
} else {
node tests\legacy-cli\run_e2e.js --nb-shards=$env:CIRCLE_NODE_TOTAL --shard=$env:CIRCLE_NODE_INDEX