Graham/angular-cli
1
0
Fork 0
mirror of https://github.com/angular/angular-cli.git synced 2025-05-16 18:43:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

test: prepare E2E tests for @angular/build project default

Browse Source 
The E2E test setup and several of the individual E2E tests have been
updated to be more robust for when the `@angular/build` package is used
as the new default. The main changes involve ensuring that the Webpack-
based `browser` builder testing uses the correct builders instead of the
new `@angular/build` variants. This change also improves the reliability of
some tests (e.g., `commands/add/version-specifier`) by not relying on outdated
versions of Angular packages.
This commit is contained in:
Charles Lyding 2025-02-20 13:05:32 -05:00 committed by Charles
parent 33aef4878d
commit f38d8df582
5 changed files with 22 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tests/legacy-cli/e2e/initialize/500-create-project.ts
View File

@ -43,6 +43,17 @@ export default async function () {
namedChunks: true,
buildOptimizer: false,
};
const serve = json['projects']['test-project']['architect']['serve'];
serve.builder = '@angular-devkit/build-angular:dev-server';
const extract = json['projects']['test-project']['architect']['extract-i18n'];
if (extract) {
extract.builder = '@angular-devkit/build-angular:extract-i18n';
}
const test = json['projects']['test-project']['architect']['test'];
test.builder = '@angular-devkit/build-angular:karma';
});
await updateJsonFile('tsconfig.json', (tsconfig) => {
delete tsconfig.compilerOptions.esModuleInterop;

3
tests/legacy-cli/e2e/tests/build/jit-ngmodule.ts
View File

@ -39,6 +39,9 @@ export default async function () {
};
build.options.aot = false;
const serve = json['projects']['test-project-two']['architect']['serve'];
serve.builder = '@angular-devkit/build-angular:dev-server';
});
// Test it works
await ng('e2e', 'test-project-two', '--configuration=production');

3
tests/legacy-cli/e2e/tests/build/rebuild-dot-dirname.ts
View File

@ -41,6 +41,9 @@ export default async function () {
namedChunks: true,
buildOptimizer: false,
};
const serve = json['projects']['subdirectory-test-project']['architect']['serve'];
serve.builder = '@angular-devkit/build-angular:dev-server';
});
}

7
tests/legacy-cli/e2e/tests/commands/add/version-specifier.ts
View File

@ -15,7 +15,7 @@ export default async function () {
await appendFile('.npmrc', '\nforce=true\n');
}
const tag = (await isPrereleaseCli()) ? '@next' : '';
const tag = isPrereleaseCli() ? '@next' : '';
await ng('add', `@angular/localize${tag}`, '--skip-confirmation');
await expectFileToMatch('package.json', /@angular\/localize/);
@ -30,13 +30,12 @@ export default async function () {
throw new Error('Installation should not have been skipped');
}
// v12.2.0 has a package.json engine field that supports Node.js v16+
const output3 = await ng('add', '@angular/localize@12.2.0', '--skip-confirmation');
const output3 = await ng('add', '@angular/localize@19.1.0', '--skip-confirmation');
if (output3.stdout.includes('Skipping installation: Package already installed')) {
throw new Error('Installation should not have been skipped');
}
const output4 = await ng('add', '@angular/localize@12', '--skip-confirmation');
const output4 = await ng('add', '@angular/localize@19', '--skip-confirmation');
if (!output4.stdout.includes('Skipping installation: Package already installed')) {
throw new Error('Installation was not skipped');
}

4
tests/legacy-cli/e2e/tests/test/test-environment.ts
View File

@ -33,8 +33,8 @@ export default function () {
production: {
fileReplacements: [
{
src: 'src/environment.ts',
replaceWith: 'src/environment.prod.ts',
replace: 'src/environment.ts',
with: 'src/environment.prod.ts',
},
],
},