From e8a97aa465e8ccdb5f29eefc03f64b21e513d409 Mon Sep 17 00:00:00 2001 From: Paul Gschwendtner Date: Tue, 21 Jan 2025 13:13:23 +0000 Subject: [PATCH] build: migrate `@angular-devkit/core/node` tests to `rules_js` Migrates the sub-entry point tests for core/node to `rules_js`. --- .../architect/node/jobs/job-registry.ts | 2 +- .../architect/node/jobs/job-registry_spec.ts | 2 +- packages/angular_devkit/core/node/BUILD.bazel | 13 +++---------- 3 files changed, 5 insertions(+), 12 deletions(-) diff --git a/packages/angular_devkit/architect/node/jobs/job-registry.ts b/packages/angular_devkit/architect/node/jobs/job-registry.ts index a130e3e23e..9237a7238c 100644 --- a/packages/angular_devkit/architect/node/jobs/job-registry.ts +++ b/packages/angular_devkit/architect/node/jobs/job-registry.ts @@ -6,9 +6,9 @@ * found in the LICENSE file at https://angular.dev/license */ -import { jobs } from '../../src'; import { JsonValue, schema } from '@angular-devkit/core'; import { Observable, of } from 'rxjs'; +import { jobs } from '../../src'; export class NodeModuleJobRegistry< MinimumArgumentValueT extends JsonValue = JsonValue, diff --git a/packages/angular_devkit/architect/node/jobs/job-registry_spec.ts b/packages/angular_devkit/architect/node/jobs/job-registry_spec.ts index 0ad30a87f1..74e03eaf3c 100644 --- a/packages/angular_devkit/architect/node/jobs/job-registry_spec.ts +++ b/packages/angular_devkit/architect/node/jobs/job-registry_spec.ts @@ -8,8 +8,8 @@ import * as path from 'path'; import { lastValueFrom } from 'rxjs'; -import { NodeModuleJobRegistry } from './job-registry'; import { jobs } from '../../src'; +import { NodeModuleJobRegistry } from './job-registry'; const root = path.join(__dirname, '../test/jobs'); diff --git a/packages/angular_devkit/core/node/BUILD.bazel b/packages/angular_devkit/core/node/BUILD.bazel index fab7df5cdf..a71aa8a285 100644 --- a/packages/angular_devkit/core/node/BUILD.bazel +++ b/packages/angular_devkit/core/node/BUILD.bazel @@ -3,8 +3,7 @@ # Use of this source code is governed by an MIT-style license that can be # found in the LICENSE file at https://angular.dev/license -load("@npm//@bazel/jasmine:index.bzl", "jasmine_node_test") -load("//tools:interop.bzl", "ts_project") +load("//tools:defaults2.bzl", "jasmine_test", "ts_project") licenses(["notice"]) @@ -28,8 +27,6 @@ ts_project( ], ) -# @external_begin - ts_project( name = "node_test_lib", testonly = True, @@ -49,11 +46,7 @@ ts_project( ], ) -jasmine_node_test( +jasmine_test( name = "node_test", - srcs = [":node_test_lib"], - deps = [ - "@npm//chokidar", - ], + data = [":node_test_lib_rjs"], ) -# @external_end