Graham/angular-cli
1
0
Fork 0
mirror of https://github.com/angular/angular-cli.git synced 2025-05-16 18:43:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(@angular-devkit/architect): set proper name in TestingArchitectHost

Browse Source 
The TestingArchitectHost registers the builders only using their name,
ignoring the package name. Later, when Architect looks up the builder
using the host, it's unable to find it.

You can find a reproduction
[here](https://github.com/mgechev/cli-builders-demo).
This commit is contained in:
Minko Gechev 2019-04-16 12:20:08 +02:00 committed by Alex Eagle
parent 0d235e1ef4
commit db3af22140
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/angular_devkit/architect/testing/testing-architect-host.ts
View File

@ -41,6 +41,10 @@ export class TestingArchitectHost implements ArchitectHost {
throw new Error('Invalid package.json, builders key not found.');
}
if (!packageJson.name) {
throw new Error('Invalid package name');
}
const builderJsonPath = packageName + '/' + packageJson['builders'];
const builderJson = await import(builderJsonPath);
const builders = builderJson['builders'];
@ -54,7 +58,7 @@ export class TestingArchitectHost implements ArchitectHost {
if (!b.implementation) { continue; }
const handler = await import(builderJsonPath + '/../' + b.implementation);
const optionsSchema = await import(builderJsonPath + '/../' + b.schema);
this.addBuilder(builderName, handler, b.description, optionsSchema);
this.addBuilder(`${packageJson.name}:${builderName}`, handler, b.description, optionsSchema);
}
}
addTarget(target: Target, builderName: string, options: json.JsonObject = {}) {