Graham/angular-cli
1
0
Fork 0
mirror of https://github.com/angular/angular-cli.git synced 2025-05-18 11:44:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(@angular-devkit/build-angular): improve detection of CommonJS dependencies

Browse Source 
With this change we include `CommonJsSelfReferenceDependency` and `CommonJsExportsDependency` in the CJS checks.

Closes #23505
This commit is contained in:
Alan Agius 2022-07-05 13:58:10 +00:00 committed by Alan Agius
parent cbccfd426a
commit d2bbcd7b68
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
packages/angular_devkit/build_angular/src/webpack/plugins/common-js-usage-warn-plugin.ts
View File

@ -12,7 +12,9 @@ import { addWarning } from '../../utils/webpack-diagnostics';
// Webpack doesn't export these so the deep imports can potentially break.
const AMDDefineDependency = require('webpack/lib/dependencies/AMDDefineDependency');
const CommonJsExportsDependency = require('webpack/lib/dependencies/CommonJsExportsDependency');
const CommonJsRequireDependency = require('webpack/lib/dependencies/CommonJsRequireDependency');
const CommonJsSelfReferenceDependency = require('webpack/lib/dependencies/CommonJsSelfReferenceDependency');
export interface CommonJsUsageWarnPluginOptions {
/** A list of CommonJS packages that are allowed to be used without a warning. */
@ -105,7 +107,12 @@ export class CommonJsUsageWarnPlugin {
checkParentModules = false,
): boolean {
for (const dep of dependencies) {
if (dep instanceof CommonJsRequireDependency || dep instanceof AMDDefineDependency) {
if (
dep instanceof CommonJsRequireDependency ||
dep instanceof CommonJsExportsDependency ||
dep instanceof CommonJsSelfReferenceDependency ||
dep instanceof AMDDefineDependency
) {
return true;
}