Graham/angular-cli
1
0
Fork 0
mirror of https://github.com/angular/angular-cli.git synced 2025-05-16 10:33:43 +08:00
Code Issues Packages Projects Releases Wiki Activity

ci: correct analytics validation script to print user custom dimensions

Browse Source 
Prior to this user custom dimensions were not added to `docs/design/analytics.md`
This commit is contained in:
Alan Agius 2022-10-12 07:06:17 +00:00 committed by Alan Agius
parent 2fb9a4dc09
commit bf7ed0d3e5
2 changed files with 9 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
docs/design/analytics.md
View File

@ -38,17 +38,14 @@ PROJECT NAME TO BUILD OR A MODULE NAME.**
<!--USER_DIMENSIONS_TABLE_BEGIN--> <!--USER_DIMENSIONS_TABLE_BEGIN-->
| Name | Parameter | Type | | Name | Parameter | Type |
|:---:|:---|:---| |:---:|:---|:---|
| Command | `ep.ng_command` | `string` | | OsArchitecture | `up.ng_os_architecture` | `string` |
| SchematicCollectionName | `ep.ng_schematic_collection_name` | `string` | | NodeVersion | `up.ng_node_version` | `string` |
| SchematicName | `ep.ng_schematic_name` | `string` | | NodeMajorVersion | `upn.ng_node_major_version` | `number` |
| Standalone | `ep.ng_standalone` | `string` | | AngularCLIVersion | `up.ng_cli_version` | `string` |
| Style | `ep.ng_style` | `string` | | AngularCLIMajorVersion | `upn.ng_cli_major_version` | `number` |
| Routing | `ep.ng_routing` | `string` | | PackageManager | `up.ng_package_manager` | `string` |
| InlineTemplate | `ep.ng_inline_template` | `string` | | PackageManagerVersion | `up.ng_package_manager_version` | `string` |
| InlineStyle | `ep.ng_inline_style` | `string` | | PackageManagerMajorVersion | `upn.ng_package_manager_major_version` | `number` |
| BuilderTarget | `ep.ng_builder_target` | `string` |
| Aot | `ep.ng_aot` | `string` |
| Optimization | `ep.ng_optimization` | `string` |
<!--USER_DIMENSIONS_TABLE_END--> <!--USER_DIMENSIONS_TABLE_END-->
### List of Event Custom Dimensions ### List of Event Custom Dimensions

4
scripts/validate-user-analytics.ts
View File

@ -28,9 +28,7 @@ const metricsTableRe = /<!--METRICS_TABLE_BEGIN-->([\s\S]*)<!--METRICS_TABLE_END
async function _checkUserDimensions(dimensionsTable: string, logger: logging.Logger) { async function _checkUserDimensions(dimensionsTable: string, logger: logging.Logger) {
logger.info('Gathering user dimensions from @angular/cli...'); logger.info('Gathering user dimensions from @angular/cli...');
const eventCustomDimensionValues = new Set(Object.values(UserCustomDimension)); const data = Object.entries(UserCustomDimension).map(([key, value]) => ({
const data = Object.entries(EventCustomDimension).map(([key, value]) => ({
parameter: value, parameter: value,
name: key, name: key,
type: value.charAt(2) === 'n' ? 'number' : 'string', type: value.charAt(2) === 'n' ? 'number' : 'string',