Graham/angular-cli
1
0
Fork 0
mirror of https://github.com/angular/angular-cli.git synced 2025-05-18 03:23:57 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(@angular-devkit/build-angular): remove babel core runtime imports from pure-toplevel-functions build optimizer pass

Browse Source 
The `pure-toplevel-functions` build optimization pass have been cleaned up
and restructured to remove the need for a direct runtime dependency on `@babel/core`.
This commit is contained in:
Charles Lyding 2024-01-29 11:27:26 -05:00 committed by Douglas Parker
parent 6a4d733dda
commit b9ec9ee688
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
packages/angular_devkit/build_angular/src/tools/babel/plugins/pure-toplevel-functions.ts
View File

@ -6,7 +6,7 @@
* found in the LICENSE file at https://angular.io/license * found in the LICENSE file at https://angular.io/license
*/ */
import { NodePath, PluginObj, types } from '@babel/core'; import type { PluginObj } from '@babel/core';
import annotateAsPure from '@babel/helper-annotate-as-pure'; import annotateAsPure from '@babel/helper-annotate-as-pure';
import * as tslib from 'tslib'; import * as tslib from 'tslib';
@ -40,28 +40,28 @@ function isTslibHelperName(name: string): boolean {
export default function (): PluginObj { export default function (): PluginObj {
return { return {
visitor: { visitor: {
CallExpression(path: NodePath<types.CallExpression>) { CallExpression(path) {
// If the expression has a function parent, it is not top-level // If the expression has a function parent, it is not top-level
if (path.getFunctionParent()) { if (path.getFunctionParent()) {
return; return;
} }
const callee = path.node.callee; const callee = path.get('callee');
if ( if (
(types.isFunctionExpression(callee) || types.isArrowFunctionExpression(callee)) && (callee.isFunctionExpression() || callee.isArrowFunctionExpression()) &&
path.node.arguments.length !== 0 path.node.arguments.length !== 0
) { ) {
return; return;
} }
// Do not annotate TypeScript helpers emitted by the TypeScript compiler. // Do not annotate TypeScript helpers emitted by the TypeScript compiler.
// TypeScript helpers are intended to cause side effects. // TypeScript helpers are intended to cause side effects.
if (types.isIdentifier(callee) && isTslibHelperName(callee.name)) { if (callee.isIdentifier() && isTslibHelperName(callee.node.name)) {
return; return;
} }
annotateAsPure(path); annotateAsPure(path);
}, },
NewExpression(path: NodePath<types.NewExpression>) { NewExpression(path) {
// If the expression has a function parent, it is not top-level // If the expression has a function parent, it is not top-level
if (!path.getFunctionParent()) { if (!path.getFunctionParent()) {
annotateAsPure(path); annotateAsPure(path);