Graham/angular-cli
1
0
Fork 0
mirror of https://github.com/angular/angular-cli.git synced 2025-05-23 15:36:23 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(@angular-devkit/build-angular): use async pipeline helper in HTML rewriting stream

Browse Source 
The Node.js async `pipeline` helper function reduces the amount of infrastructure code
needed to pipe HTML content through the parse5 transform stream.
This commit is contained in:
Charles Lyding 2024-03-04 10:29:02 -05:00 committed by Alan Agius
parent ffeb3eb74e
commit b55bbde9c3
1 changed files with 11 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
packages/angular_devkit/build_angular/src/utils/index-file/html-rewriting-stream.ts
View File

@ -6,7 +6,8 @@
* found in the LICENSE file at https://angular.io/license * found in the LICENSE file at https://angular.io/license
*/ */
import { Readable, Writable } from 'stream'; import { Readable } from 'node:stream';
import { pipeline } from 'node:stream/promises';
import { loadEsmModule } from '../load-esm'; import { loadEsmModule } from '../load-esm';
export async function htmlRewritingStream(content: string): Promise<{ export async function htmlRewritingStream(content: string): Promise<{
@ -16,42 +17,18 @@ export async function htmlRewritingStream(content: string): Promise<{
const { RewritingStream } = await loadEsmModule<typeof import('parse5-html-rewriting-stream')>( const { RewritingStream } = await loadEsmModule<typeof import('parse5-html-rewriting-stream')>(
'parse5-html-rewriting-stream', 'parse5-html-rewriting-stream',
); );
const chunks: Buffer[] = [];
const rewriter = new RewritingStream(); const rewriter = new RewritingStream();
return { return {
rewriter, rewriter,
transformedContent: () => { transformedContent: () =>
return new Promise((resolve) => { pipeline(Readable.from(content), rewriter, async function (source) {
new Readable({ const chunks = [];
encoding: 'utf8', for await (const chunk of source) {
read(): void { chunks.push(Buffer.from(chunk));
this.push(Buffer.from(content)); }
this.push(null);
}, return Buffer.concat(chunks).toString('utf-8');
}) }),
.pipe(rewriter)
.pipe(
new Writable({
write(
chunk: string | Buffer,
encoding: string | undefined,
callback: Function,
): void {
chunks.push(
typeof chunk === 'string'
? Buffer.from(chunk, encoding as BufferEncoding)
: chunk,
);
callback();
},
final(callback: (error?: Error) => void): void {
callback();
resolve(Buffer.concat(chunks).toString());
},
}),
);
});
},
}; };
} }