Graham/angular-cli
1
0
Fork 0
mirror of https://github.com/angular/angular-cli.git synced 2025-05-20 05:24:57 +08:00
Code Issues Packages Projects Releases Wiki Activity

perf(@angular-devkit/build-angular): only enable advanced optimizations with script optimizations

Browse Source 
When using the `application` or `browser-esbuild` builders, the internal advanced optimizations
can only be applied when in AOT mode. However, they were previously only checking the AOT mode
and not whether the project was configured to use script optimizations. The advanced optimizations
are now conditional on both AOT mode and the `optimization.scripts` option. This can greatly
improve the performance of builds in development since the Babel related processing can be skipped
for all TypeScript application code.
This commit is contained in:
Charles Lyding 2023-12-01 15:47:12 -05:00 committed by Charles
parent e2f92ab957
commit b10d2a7bb0
3 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/angular_devkit/build_angular/src/builders/application/options.ts
View File

@ -284,7 +284,7 @@ export async function normalizeOptions(
// Return all the normalized options
return {
advancedOptimizations: !!aot,
advancedOptimizations: !!aot && optimizationOptions.scripts,
allowedCommonJsDependencies,
baseHref,
cacheOptions,

2
packages/angular_devkit/build_angular/src/builders/application/tests/behavior/angular-aot-metadata_spec.ts
View File

@ -14,6 +14,7 @@ describeBuilder(buildApplication, APPLICATION_BUILDER_INFO, (harness) => {
it('should not emit any AOT class metadata functions', async () => {
harness.useTarget('build', {
...BASE_OPTIONS,
optimization: true,
});
const { result } = await harness.executeOnce();
@ -25,6 +26,7 @@ describeBuilder(buildApplication, APPLICATION_BUILDER_INFO, (harness) => {
it('should not emit any AOT NgModule scope metadata functions', async () => {
harness.useTarget('build', {
...BASE_OPTIONS,
optimization: true,
});
const { result } = await harness.executeOnce();

7
tests/legacy-cli/e2e/tests/build/prerender/error-with-sourcemaps.ts
View File

@ -44,5 +44,10 @@ export default async function () {
const { message } = await expectToFail(() =>
ng('build', '--configuration', 'development', '--prerender'),
);
match(message, /window is not defined[.\s\S]*constructor \(.*app\.component\.ts\:\d+:\d+\)/);
match(
message,
// When babel is used it will add names to the sourcemap and `constructor` will be used in the stack trace.
// This will currently only happen if AOT and script optimizations are set which enables advanced optimizations.
/window is not defined[.\s\S]*(?:constructor|_AppComponent) \(.*app\.component\.ts\:\d+:\d+\)/,
);
}