1
0
mirror of https://github.com/angular/angular-cli.git synced 2025-05-21 05:52:41 +08:00

refactor(@schematics/angular): remove deprecated options from app-shell and universal schematics

BREAKING CHANGE:  The below options have been removed as they had no effect
- `test` and `testTsconfigFileName` have been removed form the universal schematic
- `universalProject`, `name`, `outDir`, `root` and `index` have been removed from the app-shell schematic
This commit is contained in:
Alan Agius 2020-05-05 15:31:46 +02:00 committed by Douglas Parker
parent 0fd3c550b5
commit ac3aff20c0
4 changed files with 3 additions and 77 deletions
packages/schematics/angular

@ -148,13 +148,7 @@ function addUniversalTarget(options: AppShellOptions): Rule {
};
// Delete non-universal options.
delete universalOptions.universalProject;
delete universalOptions.route;
delete universalOptions.name;
delete universalOptions.outDir;
delete universalOptions.root;
delete universalOptions.index;
delete universalOptions.sourceDir;
return schematic('universal', universalOptions);
};

@ -17,7 +17,6 @@ describe('App Shell Schematic', () => {
require.resolve('../collection.json'),
);
const defaultOptions: AppShellOptions = {
name: 'foo',
clientProject: 'bar',
};

@ -13,74 +13,23 @@
"$source": "projectName"
}
},
"universalProject": {
"type": "string",
"description": "The name of related Universal app.",
"x-deprecated": "This option has no effect."
},
"route": {
"type": "string",
"description": "Route path used to produce the app shell.",
"default": "shell"
},
"name": {
"type": "string",
"format": "html-selector",
"description": "The HTML selector of the Universal app",
"x-deprecated": "This option has no effect."
},
"appId": {
"type": "string",
"format": "html-selector",
"description": "The app ID to use in withServerTransition().",
"default": "serverApp"
},
"outDir": {
"type": "string",
"format": "path",
"description": "The output directory for build results.",
"default": "dist-server",
"x-deprecated": "This option has no effect."
},
"root": {
"type": "string",
"format": "path",
"description": "The root directory of the app.",
"default": "src",
"x-deprecated": "This option has no effect."
},
"index": {
"type": "string",
"format": "path",
"description": "The name of the index file",
"default": "index.html",
"x-deprecated": "This option has no effect."
},
"main": {
"type": "string",
"format": "path",
"description": "The name of the main entry-point file.",
"default": "main.server.ts"
},
"test": {
"type": "string",
"format": "path",
"description": "The name of the test entry-point file.",
"x-deprecated": "This option has no effect."
},
"tsconfigFileName": {
"type": "string",
"format": "path",
"default": "tsconfig.server",
"description": "The name of the TypeScript configuration file."
},
"testTsconfigFileName": {
"type": "string",
"format": "path",
"description": "The name of the TypeScript configuration file for tests.",
"default": "tsconfig.spec",
"x-deprecated": "This option has no effect."
},
"appDir": {
"type": "string",
"format": "path",
@ -99,13 +48,10 @@
"description": "The name of the root module class.",
"default": "AppServerModule"
},
"sourceDir": {
"tsconfigFileName": {
"type": "string",
"format": "path",
"description": "The path of the source directory.",
"default": "src",
"alias": "D",
"x-deprecated": "This option has no effect."
"default": "tsconfig.server",
"description": "The name of the TypeScript configuration file."
}
},
"required": [

@ -21,24 +21,11 @@
"description": "The name of the main entry-point file.",
"default": "main.server.ts"
},
"test": {
"type": "string",
"format": "path",
"description": "The name of the test entry-point file.",
"x-deprecated": "This option has no effect."
},
"tsconfigFileName": {
"type": "string",
"default": "tsconfig.server",
"description": "The name of the TypeScript configuration file."
},
"testTsconfigFileName": {
"type": "string",
"format": "path",
"description": "The name of the TypeScript configuration file for tests.",
"default": "tsconfig.spec",
"x-deprecated": "This option has no effect."
},
"appDir": {
"type": "string",
"format": "path",