Graham/angular-cli
1
0
Fork 0
mirror of https://github.com/angular/angular-cli.git synced 2025-05-23 23:59:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

test: suppress npm update warnings

Browse Source
This commit is contained in:
Jason Bedard 2022-09-07 17:55:48 -07:00 committed by Douglas Parker
parent 13eaa3916d
commit aae30d5a84
3 changed files with 7 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tests/legacy-cli/e2e/setup/002-npm-sandbox.ts
View File

@ -41,6 +41,11 @@ export default async function () {
setGlobalVariable('npm-global', npmModulesPrefix); setGlobalVariable('npm-global', npmModulesPrefix);
setGlobalVariable('yarn-global', yarnModulesPrefix); setGlobalVariable('yarn-global', yarnModulesPrefix);
// Disable all update/notification related npm/yarn features such as the NPM updater notifier.
// The NPM updater notifier may prevent the child process from closing until it timeouts after 3 minutes.
process.env.NO_UPDATE_NOTIFIER = '1';
process.env.NPM_CONFIG_UPDATE_NOTIFIER = 'false';
console.log(` Using "${npmModulesPrefix}" as e2e test global npm bin dir.`); console.log(` Using "${npmModulesPrefix}" as e2e test global npm bin dir.`);
console.log(` Using "${yarnModulesPrefix}" as e2e test global yarn bin dir.`); console.log(` Using "${yarnModulesPrefix}" as e2e test global yarn bin dir.`);
} }

12
tests/legacy-cli/e2e/tests/misc/npm-7.ts
View File

@ -1,5 +1,4 @@
import * as assert from 'assert'; import * as assert from 'assert';
import { execSync } from 'child_process';
import { valid as validSemVer } from 'semver'; import { valid as validSemVer } from 'semver';
import { rimraf } from '../../utils/fs'; import { rimraf } from '../../utils/fs';
import { getActivePackageManager } from '../../utils/packages'; import { getActivePackageManager } from '../../utils/packages';
@ -21,16 +20,7 @@ export default async function () {
} }
// Get current package manager version to restore after tests // Get current package manager version to restore after tests
const initialVersionText = execSync('npm --version', { const initialVersionText = (await npm('--version')).stdout.trim();
encoding: 'utf8',
stdio: ['ignore', 'pipe', 'ignore'],
env: {
...process.env,
// NPM updater notifier will prevent the child process from closing until it timeouts after 3 minutes.
NO_UPDATE_NOTIFIER: '1',
NPM_CONFIG_UPDATE_NOTIFIER: 'false',
},
}).trim();
const initialVersion = validSemVer(initialVersionText); const initialVersion = validSemVer(initialVersionText);
assert.ok( assert.ok(
initialVersion, initialVersion,

2
tests/legacy-cli/e2e/utils/process.ts
View File

@ -16,7 +16,7 @@ interface ExecOptions {
cwd?: string; cwd?: string;
} }
const NPM_CONFIG_RE = /^(npm_config_|yarn_)/i; const NPM_CONFIG_RE = /^(npm_config_|yarn_|no_update_notifier)/i;
let _processes: child_process.ChildProcess[] = []; let _processes: child_process.ChildProcess[] = [];