From a7db68d2e27037bded4244e63b33630262249617 Mon Sep 17 00:00:00 2001
From: Charles Lyding <19598772+clydin@users.noreply.github.com>
Date: Wed, 12 Mar 2025 10:10:27 -0400
Subject: [PATCH] test: remove E2E test for ngrx Effect decorator usage
The `misc/third-party-decorators` E2E test has been
deleted as its purpose was to test the usage of the
now removed `Effect` decorator from `ngrx`.
---
.../e2e/tests/misc/third-party-decorators.ts | 169 ------------------
1 file changed, 169 deletions(-)
delete mode 100644 tests/legacy-cli/e2e/tests/misc/third-party-decorators.ts
diff --git a/tests/legacy-cli/e2e/tests/misc/third-party-decorators.ts b/tests/legacy-cli/e2e/tests/misc/third-party-decorators.ts
deleted file mode 100644
index c44d7373f7..0000000000
--- a/tests/legacy-cli/e2e/tests/misc/third-party-decorators.ts
+++ /dev/null
@@ -1,169 +0,0 @@
-import { writeMultipleFiles } from '../../utils/fs';
-import { installWorkspacePackages } from '../../utils/packages';
-import { ng } from '../../utils/process';
-import { updateJsonFile } from '../../utils/project';
-
-export default async function () {
- await updateJsonFile('package.json', (packageJson) => {
- // Install NGRX
- packageJson['dependencies']['@ngrx/effects'] = '^14.3.0';
- packageJson['dependencies']['@ngrx/schematics'] = '^14.3.0';
- packageJson['dependencies']['@ngrx/store'] = '^14.3.0';
- packageJson['dependencies']['@ngrx/store-devtools'] = '^14.3.0';
- });
-
- // Force is need to prevent npm 7+ from failing due to potential peer dependency resolution range errors.
- // This is especially common when testing snapshot builds for new prereleases.
- await installWorkspacePackages({ force: true });
-
- await updateJsonFile('tsconfig.json', (tsconfig) => {
- tsconfig.compilerOptions.useDefineForClassFields = false;
- });
-
- // Create an app that uses ngrx decorators and has e2e tests.
- await writeMultipleFiles({
- './e2e/src/app.po.ts': `
- import { browser, by, element } from 'protractor';
- export class AppPage {
- async navigateTo() { return browser.get('/'); }
- getIncrementButton() { return element(by.buttonText('Increment')); }
- getDecrementButton() { return element(by.buttonText('Decrement')); }
- getResetButton() { return element(by.buttonText('Reset Counter')); }
- async getCounter() { return element(by.xpath('/html/body/app-root/div/span')).getText(); }
- }
- `,
- './e2e/src/app.e2e-spec.ts': `
- import { AppPage } from './app.po';
-
- describe('workspace-project App', () => {
- let page: AppPage;
-
- beforeEach(() => {
- page = new AppPage();
- });
-
- it('should operate counter', async () => {
- await page.navigateTo();
- await page.getIncrementButton().click();
- await page.getIncrementButton().click();
- expect(await page.getCounter()).toEqual('2');
- await page.getDecrementButton().click();
- expect(await page.getCounter()).toEqual('1');
- await page.getResetButton().click();
- expect(await page.getCounter()).toEqual('0');
- });
- });
- `,
- './src/app/app.component.ts': `
- import { Component } from '@angular/core';
- import { CommonModule } from '@angular/common';
- import { Store, select } from '@ngrx/store';
- import { Observable } from 'rxjs';
- import { INCREMENT, DECREMENT, RESET } from './counter.reducer';
-
- interface AppState {
- count: number;
- }
-
- @Component({
- standalone: true,
- selector: 'app-root',
- imports: [CommonModule],
- template: \`
-
- Current Count: {{ count$ | async }}
-
-
-
- \`,
- })
- export class AppComponent {
- count$: Observable;
-
- constructor(private store: Store) {
- this.count$ = store.pipe(select(state => state.count));
- }
-
- increment() {
- this.store.dispatch({ type: INCREMENT });
- }
-
- decrement() {
- this.store.dispatch({ type: DECREMENT });
- }
-
- reset() {
- this.store.dispatch({ type: RESET });
- }
- }
- `,
- './src/app/app.effects.ts': `
- import { Injectable } from '@angular/core';
- import { Actions, Effect } from '@ngrx/effects';
- import { filter, map, tap } from 'rxjs/operators';
-
- @Injectable()
- export class AppEffects {
-
- @Effect()
- mapper$ = this.actions$.pipe(map(() => ({ type: 'ANOTHER'})), filter(() => false));
-
- @Effect({ dispatch: false })
- logger$ = this.actions$.pipe(tap(console.log));
-
- constructor(private actions$: Actions) {}
- }
- `,
- './src/app/app.config.ts': `
- import { ApplicationConfig, importProvidersFrom } from '@angular/core';
- import { provideRouter } from '@angular/router';
- import { provideProtractorTestingSupport } from '@angular/platform-browser';
- import { AppComponent } from './app.component';
- import { StoreModule } from '@ngrx/store';
- import { StoreDevtoolsModule } from '@ngrx/store-devtools';
- import { EffectsModule } from '@ngrx/effects';
- import { AppEffects } from './app.effects';
- import { counterReducer } from './counter.reducer';
-
- import { routes } from './app.routes';
-
- export const appConfig: ApplicationConfig = {
- providers: [
- provideProtractorTestingSupport(),
- provideRouter(routes),
- importProvidersFrom(StoreModule.forRoot({ count: counterReducer })),
- importProvidersFrom(StoreDevtoolsModule.instrument()),
- importProvidersFrom(EffectsModule.forRoot([AppEffects])),
- ]
- };
- `,
- './src/app/counter.reducer.ts': `
- import { Action } from '@ngrx/store';
-
- export const INCREMENT = 'INCREMENT';
- export const DECREMENT = 'DECREMENT';
- export const RESET = 'RESET';
-
- const initialState = 0;
-
- export function counterReducer(state: number = initialState, action: Action) {
- switch (action.type) {
- case INCREMENT:
- return state + 1;
-
- case DECREMENT:
- return state - 1;
-
- case RESET:
- return 0;
-
- default:
- return state;
- }
- }
- `,
- });
-
- // Run the e2e tests against a production build.
- await ng('e2e', '--configuration=production');
-}