From 9bd93579c7cb72221f918a5c2d147672ad5b75bf Mon Sep 17 00:00:00 2001 From: Charles Lyding <19598772+clydin@users.noreply.github.com> Date: Fri, 8 Mar 2019 11:17:15 -0500 Subject: [PATCH] test(@angular-devkit/build-angular): ensure server address type before use --- .../build_angular/test/dev-server/proxy_spec_large.ts | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/angular_devkit/build_angular/test/dev-server/proxy_spec_large.ts b/packages/angular_devkit/build_angular/test/dev-server/proxy_spec_large.ts index e10488be41..e73f93df4d 100644 --- a/packages/angular_devkit/build_angular/test/dev-server/proxy_spec_large.ts +++ b/packages/angular_devkit/build_angular/test/dev-server/proxy_spec_large.ts @@ -9,12 +9,12 @@ import { request, runTargetSpec } from '@angular-devkit/architect/testing'; import * as express from 'express'; // tslint:disable-line:no-implicit-dependencies import * as http from 'http'; +import { AddressInfo } from 'net'; import { from } from 'rxjs'; import { concatMap, take, tap } from 'rxjs/operators'; import { Schema as DevServerBuilderOptions } from '../../src/dev-server/schema'; import { devServerTargetSpec, host } from '../utils'; - describe('Dev Server Builder proxy', () => { beforeEach(done => host.initialize().toPromise().then(done, done.fail)); afterEach(done => host.restore().toPromise().then(done, done.fail)); @@ -25,13 +25,15 @@ describe('Dev Server Builder proxy', () => { const server = http.createServer(app); server.listen(0); - app.set('port', server.address().port); + // cast is safe, the HTTP server is not using a pipe or UNIX domain socket + app.set('port', (server.address() as AddressInfo).port); app.get('/api/test', function (_req, res) { res.send('TEST_API_RETURN'); }); const backendHost = 'localhost'; - const backendPort = server.address().port; + // cast is safe, the HTTP server is not using a pipe or UNIX domain socket + const backendPort = (server.address() as AddressInfo).port; const proxyServerUrl = `http://${backendHost}:${backendPort}`; host.writeMultipleFiles({