Graham/angular-cli
1
0
Fork 0
mirror of https://github.com/angular/angular-cli.git synced 2025-05-16 10:33:43 +08:00
Code Issues Packages Projects Releases Wiki Activity

build: use rbe platform with network from shared dev-infra build tooling

Browse Source 
This avoids having to manually declare the `platform`. We specifically
added support for the network platform due to the CLI needs.

The CLI repository should long-term set
`--sandbox_default_allow_network=false` in the `bazelrc` so that
internet access is only granted targets explicitly. We should discourage
reliance on internet as much as possible to help with hermetic tests.
This commit is contained in:
Paul Gschwendtner 2022-07-27 08:14:10 +00:00 committed by Alan Agius
parent 087ab46ca9
commit 96d39f8f3a
2 changed files with 3 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
.bazelrc
View File

@ -120,9 +120,9 @@ build:remote --jobs=150
# is provided by the shared dev-infra package and targets k8 remote containers.
build:remote --crosstool_top=@npm//@angular/build-tooling/bazel/remote-execution/cpp:cc_toolchain_suite
build:remote --extra_toolchains=@npm//@angular/build-tooling/bazel/remote-execution/cpp:cc_toolchain
build:remote --extra_execution_platforms=//tools:rbe_platform_with_network_access
build:remote --host_platform=//tools:rbe_platform_with_network_access
build:remote --platforms=//tools:rbe_platform_with_network_access
build:remote --extra_execution_platforms=@npm//@angular/build-tooling/bazel/remote-execution:platform_with_network
build:remote --host_platform=@npm//@angular/build-tooling/bazel/remote-execution:platform_with_network
build:remote --platforms=@npm//@angular/build-tooling/bazel/remote-execution:platform_with_network
# Set remote caching settings
build:remote --remote_accept_cached=true

9
tools/BUILD.bazel
View File

@ -28,13 +28,4 @@ nodejs_binary(
entry_point = "quicktype_runner.js",
templated_args = ["--bazel_patch_module_resolver"],
)
platform(
name = "rbe_platform_with_network_access",
exec_properties = {
"dockerNetwork": "standard",
},
parents = ["@npm//@angular/build-tooling/bazel/remote-execution:platform"],
)
# @external_end