Graham/angular-cli
1
0
Fork 0
mirror of https://github.com/angular/angular-cli.git synced 2025-05-14 17:43:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(@angular/build): allow component update invalidation from client

Browse Source 
If HMR is enabled, a component update has the potential to be unsupported
at runtime or may cause an exception. While build time analysis attempts
to verify that an update is possible, there could be cases that are as of
yet unknown. For those cases, the runtime can now signal this information
back to the development server which will clear the errant component update
and trigger a full page reload. This action will be logged to the development
server console along with an optional message from the client.
This commit is contained in:
Charles Lyding 2025-01-28 18:08:22 -05:00 committed by Charles
parent 25dbe7cfc1
commit 9525eee739
1 changed files with 35 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
packages/angular/build/src/builders/dev-server/vite-server.ts
View File

@ -457,6 +457,41 @@ export async function* serveWithVite(
}
});
// Setup component HMR invalidation
// Invalidation occurs when the runtime cannot update a component
server.hot.on(
'angular:invalidate',
(data: { id: string; message?: string; error?: boolean }) => {
if (typeof data?.id !== 'string') {
context.logger.warn(
'Development server client sent invalid internal invalidate event.',
);
}
// Clear invalid template update
templateUpdates.delete(data.id);
// Some cases are expected unsupported update scenarios but some may be errors.
// If an error occurred, log the error in addition to the invalidation.
if (data.error) {
context.logger.error(
`Component update failed${data.message ? `: ${data.message}` : '.'}` +
'\nPlease consider reporting the error at https://github.com/angular/angular-cli/issues',
);
} else {
context.logger.warn(
`Component update unsupported${data.message ? `: ${data.message}` : '.'}`,
);
}
server?.ws.send({
type: 'full-reload',
path: '*',
});
context.logger.info('Page reload sent to client(s).');
},
);
const urls = server.resolvedUrls;
if (urls && (urls.local.length || urls.network.length)) {
serverUrl = new URL(urls.local[0] ?? urls.network[0]);