Graham/angular-cli
1
0
Fork 0
mirror of https://github.com/angular/angular-cli.git synced 2025-05-17 02:54:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

test(@angular-devkit/build-angular): avoid crashing during test failure in utility function

Browse Source 
Previously, if a browser build failed using the `browserBuild` test utility function, the test utility would try to access properties that did not exist and would crash. This increased the complexity to debug failing tests. With the new behavior, the `browserBuild` test utility will return with an empty `files` object and the failed builder result.
This commit is contained in:
Charles Lyding 2021-03-16 13:06:54 -04:00 committed by Alan Agius
parent 2327ddc2f9
commit 8e5b83ba66
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
packages/angular_devkit/build_angular/src/test-utils.ts
View File

@ -81,6 +81,15 @@ export async function browserBuild(
const output = (await run.result) as BrowserBuilderOutput; const output = (await run.result) as BrowserBuilderOutput;
expect(output.success).toBe(true); expect(output.success).toBe(true);
if (!output.success) {
await run.stop();
return {
output,
files: {},
};
}
expect(output.outputPaths[0]).not.toBeUndefined(); expect(output.outputPaths[0]).not.toBeUndefined();
const outputPath = normalize(output.outputPaths[0]); const outputPath = normalize(output.outputPaths[0]);