Graham/angular-cli
1
0
Fork 0
mirror of https://github.com/angular/angular-cli.git synced 2025-05-18 03:23:57 +08:00
Code Issues Packages Projects Releases Wiki Activity

ci: set CHROME_PATH environment variable to Bazel's Chrome install

Browse Source 
This variable is used by Chrome launcher under Web Test Runner to find and execute Chrome.
This commit is contained in:
Doug Parker 2024-01-04 09:41:52 -08:00 committed by Douglas Parker
parent 5495819d19
commit 7bf4dd6eaf
3 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tests/legacy-cli/e2e.bzl
View File

@ -103,6 +103,7 @@ def _e2e_tests(name, runner, **kwargs):
# Chromium browser toolchain # Chromium browser toolchain
env.update({ env.update({
"CHROME_BIN": "$(CHROMIUM)", "CHROME_BIN": "$(CHROMIUM)",
"CHROME_PATH": "$(CHROMIUM)",
"CHROMEDRIVER_BIN": "$(CHROMEDRIVER)", "CHROMEDRIVER_BIN": "$(CHROMEDRIVER)",
}) })
toolchains = toolchains + ["@npm//@angular/build-tooling/bazel/browsers/chromium:toolchain_alias"] toolchains = toolchains + ["@npm//@angular/build-tooling/bazel/browsers/chromium:toolchain_alias"]

1
tests/legacy-cli/e2e/utils/process.ts
View File

@ -177,6 +177,7 @@ function extractCIEnv(): NodeJS.ProcessEnv {
v === 'CI' || v === 'CI' ||
v === 'CIRCLECI' || v === 'CIRCLECI' ||
v === 'CHROME_BIN' || v === 'CHROME_BIN' ||
v === 'CHROME_PATH' ||
v === 'CHROMEDRIVER_BIN', v === 'CHROMEDRIVER_BIN',
) )
.reduce<NodeJS.ProcessEnv>((vars, n) => { .reduce<NodeJS.ProcessEnv>((vars, n) => {

1
tests/legacy-cli/e2e_runner.ts
View File

@ -206,6 +206,7 @@ setGlobalVariable('package-manager', argv.yarn ? 'yarn' : 'npm');
// Resolve from relative paths to absolute paths within the bazel runfiles tree // Resolve from relative paths to absolute paths within the bazel runfiles tree
// so subprocesses spawned in a different working directory can still find them. // so subprocesses spawned in a different working directory can still find them.
process.env.CHROME_BIN = path.resolve(process.env.CHROME_BIN!); process.env.CHROME_BIN = path.resolve(process.env.CHROME_BIN!);
process.env.CHROME_PATH = path.resolve(process.env.CHROME_PATH!);
process.env.CHROMEDRIVER_BIN = path.resolve(process.env.CHROMEDRIVER_BIN!); process.env.CHROMEDRIVER_BIN = path.resolve(process.env.CHROMEDRIVER_BIN!);
Promise.all([findFreePort(), findFreePort(), findPackageTars()]) Promise.all([findFreePort(), findFreePort(), findPackageTars()])