Graham/angular-cli
1
0
Fork 0
mirror of https://github.com/angular/angular-cli.git synced 2025-05-15 01:54:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(@schematics/angular): add migration to update web-animations-js polyfill

Browse Source 
Previous versions rely on `this` which breaks differential loading since it's `undefined` when using script tags with type module.

Fixes #14518
This commit is contained in:
Alan Agius 2019-05-28 19:38:55 +02:00 committed by Alex Eagle
parent 757d8df3e6
commit 3afdab21a0
2 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/schematics/angular/migrations/update-8/index.ts
View File

@ -12,7 +12,7 @@ import { updatePackageJson, updateTsLintConfig } from './codelyzer-5';
import { updateES5Projects } from './differential-loading';
import { dropES2015Polyfills } from './drop-es6-polyfills';
import { removeAngularHttp } from './remove-angular-http';
import { updateBuilders } from './update-builders';
import { updateDependencies } from './update-dependencies';
export { updateLazyModulePaths } from './update-lazy-module-paths';
@ -23,7 +23,7 @@ export default function(): Rule {
updatePackageJson(),
dropES2015Polyfills(),
updateES5Projects(),
updateBuilders(),
updateDependencies(),
removeAngularHttp(),
(tree, context) => {
const packageChanges = tree.actions.some(a => a.path.endsWith('/package.json'));

17
packages/schematics/angular/migrations/update-8/update-builders.ts → packages/schematics/angular/migrations/update-8/update-dependencies.ts
View File

@ -9,7 +9,7 @@ import { Tree } from '@angular-devkit/schematics';
import { addPackageJsonDependency, getPackageJsonDependency } from '../../utility/dependencies';
import { latestVersions } from '../../utility/latest-versions';
export function updateBuilders() {
export function updateDependencies() {
return (host: Tree) => {
let current = getPackageJsonDependency(host, '@angular-devkit/build-angular');
if (current && current.version !== latestVersions.DevkitBuildAngular) {
@ -49,5 +49,20 @@ export function updateBuilders() {
},
);
}
// FIXME: change to ^2.3.2 as soon as it's released with the pr208 fix
const webAnimationsJsVersion = 'github:angular/web-animations-js#release_pr208';
current = getPackageJsonDependency(host, 'web-animations-js');
if (current && current.version !== webAnimationsJsVersion) {
addPackageJsonDependency(
host,
{
type: current.type,
name: 'web-animations-js',
version: webAnimationsJsVersion,
overwrite: true,
},
);
}
};
}