Graham/angular-cli
1
0
Fork 0
mirror of https://github.com/angular/angular-cli.git synced 2025-05-21 05:52:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(@angular/build): lazy load Node.js inspector for dev server

Browse Source 
The Node.js inspector will now only be imported if SSR is enabled and
the `inspect` option is used. This prevents potential failures when a
custom Node.js binary build is used that has not enabled inspector usage.
While this is not common, loading the inspector on demand is a minimal
change that also avoids loading code that will not be used for the majority
of development server usage.
This commit is contained in:
Charles Lyding 2024-08-07 11:16:37 -04:00 committed by Charles
parent c4fa7b65cb
commit 34908a3fcb
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/angular/build/src/builders/dev-server/vite-server.ts
View File

@ -10,7 +10,6 @@ import type { BuilderContext } from '@angular-devkit/architect';
import type { Plugin } from 'esbuild'; import type { Plugin } from 'esbuild';
import assert from 'node:assert'; import assert from 'node:assert';
import { readFile } from 'node:fs/promises'; import { readFile } from 'node:fs/promises';
import inspector from 'node:inspector';
import { builtinModules } from 'node:module'; import { builtinModules } from 'node:module';
import { join } from 'node:path'; import { join } from 'node:path';
import type { Connect, DepOptimizationConfig, InlineConfig, ViteDevServer } from 'vite'; import type { Connect, DepOptimizationConfig, InlineConfig, ViteDevServer } from 'vite';
@ -275,6 +274,7 @@ export async function* serveWithVite(
if (browserOptions.ssr && serverOptions.inspect) { if (browserOptions.ssr && serverOptions.inspect) {
const { host, port } = serverOptions.inspect as { host?: string; port?: number }; const { host, port } = serverOptions.inspect as { host?: string; port?: number };
const { default: inspector } = await import('node:inspector');
inspector.open(port, host, true); inspector.open(port, host, true);
context.addTeardown(() => inspector.close()); context.addTeardown(() => inspector.close());
} }