Graham/angular-cli
1
0
Fork 0
mirror of https://github.com/angular/angular-cli.git synced 2025-05-19 04:26:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(@angular/cli): remove broken script after eject

Browse Source 
`prepree2e` doesn't run because it's a lifecycle script for a lifecycle script, but even if it did it would not work because there is nothing coordinating the serve and e2e processes.

Users must manually initialize the server prior to running e2e tests after ejecting.

Related to https://github.com/angular/angular-cli/issues/6171
This commit is contained in:
Filipe Silva 2017-05-22 11:42:05 +01:00 committed by Mike Brocchi
parent 403bf7efb1
commit 2b2e8b3685
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
packages/@angular/cli/tasks/eject.ts
View File

@ -427,12 +427,6 @@ export default Task.extend({
Your package.json scripts must not contain a start script as it will be overwritten. Your package.json scripts must not contain a start script as it will be overwritten.
`); `);
} }
if (scripts['pree2e'] && scripts['prepree2e'] !== 'npm start' && !force) {
throw new SilentError(oneLine`
Your package.json scripts needs to not contain a prepree2e script as it will be
overwritten.
`);
}
if (scripts['pree2e'] && scripts['pree2e'] !== pree2eNpmScript && !force) { if (scripts['pree2e'] && scripts['pree2e'] !== pree2eNpmScript && !force) {
throw new SilentError(oneLine` throw new SilentError(oneLine`
Your package.json scripts must not contain a pree2e script as it will be Your package.json scripts must not contain a pree2e script as it will be
@ -453,7 +447,6 @@ export default Task.extend({
packageJson['scripts']['build'] = 'webpack'; packageJson['scripts']['build'] = 'webpack';
packageJson['scripts']['start'] = 'webpack-dev-server --port=4200'; packageJson['scripts']['start'] = 'webpack-dev-server --port=4200';
packageJson['scripts']['test'] = 'karma start ./karma.conf.js'; packageJson['scripts']['test'] = 'karma start ./karma.conf.js';
packageJson['scripts']['prepree2e'] = 'npm start';
packageJson['scripts']['pree2e'] = pree2eNpmScript; packageJson['scripts']['pree2e'] = pree2eNpmScript;
packageJson['scripts']['e2e'] = 'protractor ./protractor.conf.js'; packageJson['scripts']['e2e'] = 'protractor ./protractor.conf.js';