Graham/angular-cli
1
0
Fork 0
mirror of https://github.com/angular/angular-cli.git synced 2025-05-23 07:19:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(@schematics/angular): normalize differing TS AST versions in lazy module migration

Browse Source
This commit is contained in:
Charles Lyding 2019-04-25 22:59:39 -04:00 committed by Alex Eagle
parent 5f248204ec
commit 2acded4bdd
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
packages/schematics/angular/migrations/update-8/rules/noLazyModulePathsRule.ts
View File

@ -21,7 +21,16 @@ export class Rule extends Rules.AbstractRule {
const ruleName = this.ruleName; const ruleName = this.ruleName;
const changes: RuleFailure[] = []; const changes: RuleFailure[] = [];
ts.forEachChild(ast, function analyze(node) { // NOTE: This should ideally be excluded at a higher level to avoid parsing
if (ast.isDeclarationFile || /[\\\/]node_modules[\\\/]/.test(ast.fileName)) {
return [];
}
// Workaround mismatched tslint TS version and vendored TS version
// The TS SyntaxKind enum numeric values change between versions
const sourceFile = ts.createSourceFile(ast.fileName, ast.text, ast.languageVersion, true);
ts.forEachChild(sourceFile, function analyze(node) {
if (ts.isPropertyAssignment(node) && if (ts.isPropertyAssignment(node) &&
(ts.isIdentifier(node.name) || ts.isStringLiteral(node.name)) && (ts.isIdentifier(node.name) || ts.isStringLiteral(node.name)) &&
node.name.text === 'loadChildren' && node.name.text === 'loadChildren' &&