From 28721c3e64cb6c70be864c970b6d55fca8526a60 Mon Sep 17 00:00:00 2001 From: alkavats1 Date: Wed, 30 Mar 2022 19:34:25 +0530 Subject: [PATCH] refactor(@angular/cli): improved code quality removed unused parameter and improved code quality --- lib/bootstrap-local.js | 1 - packages/angular/cli/src/commands/analytics/cli.ts | 2 +- packages/angular/cli/src/commands/analytics/info/cli.ts | 2 +- .../angular/cli/src/commands/analytics/settings/cli.ts | 2 +- packages/angular/cli/src/commands/doc/cli.ts | 2 +- packages/angular/cli/src/commands/e2e/cli.ts | 8 ++++---- 6 files changed, 8 insertions(+), 9 deletions(-) diff --git a/lib/bootstrap-local.js b/lib/bootstrap-local.js index bcc5b006ee..dd8fe3e481 100644 --- a/lib/bootstrap-local.js +++ b/lib/bootstrap-local.js @@ -87,7 +87,6 @@ const packages = require('./packages').packages; if (!__dirname.match(new RegExp(`\\${path.sep}node_modules\\${path.sep}`))) { // We mock the module loader so that we can fake our packages when running locally. const Module = require('module'); - const oldLoad = Module._load; const oldResolve = Module._resolveFilename; Module._resolveFilename = function (request, parent) { diff --git a/packages/angular/cli/src/commands/analytics/cli.ts b/packages/angular/cli/src/commands/analytics/cli.ts index ccfdf9d7df..828f2d6cb4 100644 --- a/packages/angular/cli/src/commands/analytics/cli.ts +++ b/packages/angular/cli/src/commands/analytics/cli.ts @@ -27,7 +27,7 @@ export class AnalyticsCommandModule extends CommandModule implements CommandModu command = 'analytics'; describe = 'Configures the gathering of Angular CLI usage metrics. See https://angular.io/cli/usage-analytics-gathering'; - longDescriptionPath?: string | undefined; + longDescriptionPath?: string; builder(localYargs: Argv): Argv { const subcommands = [ diff --git a/packages/angular/cli/src/commands/analytics/info/cli.ts b/packages/angular/cli/src/commands/analytics/info/cli.ts index fd692e0ad8..271cbb2103 100644 --- a/packages/angular/cli/src/commands/analytics/info/cli.ts +++ b/packages/angular/cli/src/commands/analytics/info/cli.ts @@ -20,7 +20,7 @@ export class AnalyticsInfoCommandModule { command = 'info'; describe = 'Prints analytics gathering and reporting configuration in the console.'; - longDescriptionPath?: string | undefined; + longDescriptionPath?: string; builder(localYargs: Argv): Argv { return localYargs.strict(); diff --git a/packages/angular/cli/src/commands/analytics/settings/cli.ts b/packages/angular/cli/src/commands/analytics/settings/cli.ts index 69ec3f3684..8fc930afe5 100644 --- a/packages/angular/cli/src/commands/analytics/settings/cli.ts +++ b/packages/angular/cli/src/commands/analytics/settings/cli.ts @@ -26,7 +26,7 @@ abstract class AnalyticsSettingModule extends CommandModule implements CommandModuleImplementation { - longDescriptionPath?: string | undefined; + longDescriptionPath?: string; builder(localYargs: Argv): Argv { return localYargs diff --git a/packages/angular/cli/src/commands/doc/cli.ts b/packages/angular/cli/src/commands/doc/cli.ts index fd2423e360..067f487dcb 100644 --- a/packages/angular/cli/src/commands/doc/cli.ts +++ b/packages/angular/cli/src/commands/doc/cli.ts @@ -28,7 +28,7 @@ export class DocCommandModule aliases = ['d']; describe = 'Opens the official Angular documentation (angular.io) in a browser, and searches for a given keyword.'; - longDescriptionPath?: string | undefined; + longDescriptionPath?: string; builder(localYargs: Argv): Argv { return localYargs diff --git a/packages/angular/cli/src/commands/e2e/cli.ts b/packages/angular/cli/src/commands/e2e/cli.ts index bb59ca78fc..f90a755442 100644 --- a/packages/angular/cli/src/commands/e2e/cli.ts +++ b/packages/angular/cli/src/commands/e2e/cli.ts @@ -17,19 +17,19 @@ export class E2eCommandModule multiTarget = true; override missingErrorTarget = tags.stripIndents` Cannot find "e2e" target for the specified project. - + You should add a package that implements end-to-end testing capabilities. - + For example: Cypress: ng add @cypress/schematic Nightwatch: ng add @nightwatch/schematics WebdriverIO: ng add @wdio/schematics - + More options will be added to the list as they become available. `; command = 'e2e [project]'; aliases = ['e']; describe = 'Builds and serves an Angular application, then runs end-to-end tests.'; - longDescriptionPath?: string | undefined; + longDescriptionPath?: string; }