Graham/angular-cli
1
0
Fork 0
mirror of https://github.com/angular/angular-cli.git synced 2025-05-17 19:13:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(@angular-devkit/build-angular): watch symbolic links

Browse Source 
This commit addresses an issue which caused symbolic links not to be watched properly.

Closes #15100
This commit is contained in:
Alan Agius 2022-09-14 07:31:44 +00:00 committed by Douglas Parker
parent 25ef9e7890
commit 2021e66a12
2 changed files with 40 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
packages/angular_devkit/build_angular/src/webpack/configs/common.ts
View File

@ -334,8 +334,17 @@ export async function getCommonConfig(wco: WebpackConfigOptions): Promise<Config
watch: buildOptions.watch,
watchOptions: {
poll,
// The below is needed as when preserveSymlinks is enabled we disable `resolve.symlinks`.
followSymlinks: buildOptions.preserveSymlinks,
ignored: poll === undefined ? undefined : '**/node_modules/**',
},
snapshot: {
module: {
// Use hash of content instead of timestamp because the timestamp of the symlink will be used
// instead of the referenced files which causes changes in symlinks not to be picked up.
hash: buildOptions.preserveSymlinks,
},
},
performance: {
hints: false,
},

31
tests/legacy-cli/e2e/tests/build/rebuild-symlink.ts Normal file
View File

@ -0,0 +1,31 @@
import { symlink } from 'fs/promises';
import { resolve } from 'path';
import { appendToFile, expectFileToMatch, writeMultipleFiles } from '../../utils/fs';
import { execAndWaitForOutputToMatch, waitForAnyProcessOutputToMatch } from '../../utils/process';
import { updateJsonFile } from '../../utils/project';
const buildReadyRegEx = /Build at: /;
export default async function () {
await updateJsonFile('angular.json', (configJson) => {
configJson.projects['test-project'].architect.build.options.preserveSymlinks = true;
});
await writeMultipleFiles({
'src/link-source.ts': '// empty file',
'src/main.ts': `import './link-dest';`,
});
await symlink(resolve('src/link-source.ts'), resolve('src/link-dest.ts'));
await execAndWaitForOutputToMatch(
'ng',
['build', '--watch', '--configuration=development'],
buildReadyRegEx,
);
// Trigger a rebuild
await appendToFile('src/link-source.ts', `console.log('foo-bar');`);
await waitForAnyProcessOutputToMatch(buildReadyRegEx);
await expectFileToMatch('dist/test-project/main.js', `console.log('foo-bar')`);
}