Graham/angular-cli
1
0
Fork 0
mirror of https://github.com/angular/angular-cli.git synced 2025-05-27 18:29:47 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor: remove path mappings from NgccProcessor

Browse Source 
Path mappings are now inferred from the provided `tsconfig.json`, thus it's now redundant to provide them.
This commit is contained in:
Alan Agius 2020-06-10 12:41:35 +02:00 committed by Filipe Silva
parent a6bf23b526
commit 1f04bf7c93
2 changed files with 1 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/ngtools/webpack/src/angular_compiler_plugin.ts
View File

@ -765,7 +765,6 @@ export class AngularCompilerPlugin {
this._warnings,
this._errors,
this._basePath,
this._compilerOptions,
this._tsConfigPath,
);

15
packages/ngtools/webpack/src/ngcc_processor.ts
View File

@ -6,7 +6,7 @@
* found in the LICENSE file at https://angular.io/license
*/
import { LogLevel, Logger, PathMappings, process as mainNgcc } from '@angular/compiler-cli/ngcc';
import { LogLevel, Logger, process as mainNgcc } from '@angular/compiler-cli/ngcc';
import { spawnSync } from 'child_process';
import { accessSync, constants, existsSync } from 'fs';
import * as path from 'path';
@ -28,7 +28,6 @@ export class NgccProcessor {
private _processedModules = new Set<string>();
private _logger: NgccLogger;
private _nodeModulesDirectory: string;
private _pathMappings: PathMappings | undefined;
constructor(
private readonly propertiesToConsider: string[],
@ -36,19 +35,10 @@ export class NgccProcessor {
private readonly compilationWarnings: (Error | string)[],
private readonly compilationErrors: (Error | string)[],
private readonly basePath: string,
private readonly compilerOptions: ts.CompilerOptions,
private readonly tsConfigPath: string,
) {
this._logger = new NgccLogger(this.compilationWarnings, this.compilationErrors);
this._nodeModulesDirectory = this.findNodeModulesDirectory(this.basePath);
const { baseUrl, paths } = this.compilerOptions;
if (baseUrl && paths) {
this._pathMappings = {
baseUrl,
paths,
};
}
}
/** Process the entire node modules tree. */
@ -130,9 +120,6 @@ export class NgccProcessor {
compileAllFormats: false,
createNewEntryPointFormats: true,
logger: this._logger,
// Path mappings are not longer required since NGCC 9.1
// We keep using them to be backward compatible with NGCC 9.0
pathMappings: this._pathMappings,
tsConfigPath: this.tsConfigPath,
});
timeEnd(timeLabel);