Graham/angular-cli
1
0
Fork 0
mirror of https://github.com/angular/angular-cli.git synced 2025-05-17 19:13:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(@angular-devkit/core): delete deepCopy temporary symbol property after use

Browse Source 
The `deepCopy` utility function previously set its internal tracking symbol property to `undefined` after completion.
However, this still caused the property to exist with a value of `undefined`. Jasmine 4.1 now checks for symbols with
its `toEqual` expectation which resulted in failing tests. The internal tracking symbol property is now removed instead
via `delete`.
This commit is contained in:
Charles Lyding 2022-05-04 11:48:11 -04:00 committed by Douglas Parker
parent 0e4e490448
commit 13fce451d8
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/angular_devkit/core/src/utils/object.ts
View File

@ -33,7 +33,7 @@ export function deepCopy<T>(value: T): T {
for (const key of Object.getOwnPropertyNames(valueCasted)) { for (const key of Object.getOwnPropertyNames(valueCasted)) {
copy[key] = deepCopy(valueCasted[key]); copy[key] = deepCopy(valueCasted[key]);
} }
valueCasted[copySymbol] = undefined; delete valueCasted[copySymbol];
return copy; return copy;
} else { } else {