Graham/angular-cli
1
0
Fork 0
mirror of https://github.com/angular/angular-cli.git synced 2025-05-21 22:34:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(@angular-devkit/core): remove fast-json-stable-stringify usage in memoize helper

Browse Source 
This is not needed as inputs are typed checked to be `JsonValue`. With this change we get a step closer to remove `fast-json-stable-stringify` dependency.
This commit is contained in:
Alan Agius 2022-04-13 19:39:29 +02:00 committed by Douglas Parker
parent 607a723f7d
commit 108a0b6acd
1 changed files with 14 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
packages/angular_devkit/core/src/experimental/jobs/strategy.ts
View File

@ -6,10 +6,9 @@
* found in the LICENSE file at https://angular.io/license * found in the LICENSE file at https://angular.io/license
*/ */
import stableStringify from 'fast-json-stable-stringify';
import { Observable, Subject, concat, of } from 'rxjs'; import { Observable, Subject, concat, of } from 'rxjs';
import { finalize, ignoreElements, share, shareReplay, tap } from 'rxjs/operators'; import { finalize, ignoreElements, share, shareReplay, tap } from 'rxjs/operators';
import { JsonValue } from '../../json'; import { JsonObject, JsonValue, isJsonObject } from '../../json';
import { import {
JobDescription, JobDescription,
JobHandler, JobHandler,
@ -60,7 +59,7 @@ export namespace strategy {
/** /**
* Creates a JobStrategy that will always reuse a running job, and restart it if the job ended. * Creates a JobStrategy that will always reuse a running job, and restart it if the job ended.
* @param replayMessages Replay ALL messages if a job is reused, otherwise just hook up where it * @param replayMessages Replay ALL messages if a job is reused, otherwise just hook up where it
* is. * is.
*/ */
export function reuse< export function reuse<
A extends JsonValue = JsonValue, A extends JsonValue = JsonValue,
@ -115,7 +114,7 @@ export namespace strategy {
/** /**
* Creates a JobStrategy that will reuse a running job if the argument matches. * Creates a JobStrategy that will reuse a running job if the argument matches.
* @param replayMessages Replay ALL messages if a job is reused, otherwise just hook up where it * @param replayMessages Replay ALL messages if a job is reused, otherwise just hook up where it
* is. * is.
*/ */
export function memoize< export function memoize<
A extends JsonValue = JsonValue, A extends JsonValue = JsonValue,
@ -126,7 +125,17 @@ export namespace strategy {
return (handler, options) => { return (handler, options) => {
const newHandler = (argument: A, context: JobHandlerContext<A, I, O>) => { const newHandler = (argument: A, context: JobHandlerContext<A, I, O>) => {
const argumentJson = stableStringify(argument); const argumentJson = JSON.stringify(
isJsonObject(argument)
? Object.keys(argument)
.sort()
.reduce((result, key) => {
result[key] = argument[key];
return result;
}, {} as JsonObject)
: argument,
);
const maybeJob = runs.get(argumentJson); const maybeJob = runs.get(argumentJson);
if (maybeJob) { if (maybeJob) {