Graham/angular-cli
1
0
Fork 0
mirror of https://github.com/angular/angular-cli.git synced 2025-05-17 02:54:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat(@angular-devkit/build-angular): remove experimentalImportFactories option

Browse Source 
It will just be always be used when applicable.

Fix #14218
This commit is contained in:
Filipe Silva 2019-04-22 17:04:54 +01:00 committed by Alex Eagle
parent 5b5fffbb5b
commit 0f9de92dcb
5 changed files with 0 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/angular/cli/lib/config/schema.json
View File

@ -886,11 +886,6 @@
"webWorkerTsConfig": { "webWorkerTsConfig": {
"type": "string", "type": "string",
"description": "TypeScript configuration for Web Worker modules." "description": "TypeScript configuration for Web Worker modules."
},
"experimentalImportFactories": {
"description": "**EXPERIMENTAL** Transform import statements for lazy routes to import factories when using View Engine. Should only be used when switching back and forth between View Engine and Ivy. See https://angular.io/guide/ivy for usage information.",
"type": "boolean",
"default": false
} }
}, },
"additionalProperties": false, "additionalProperties": false,

1
packages/angular_devkit/build_angular/src/angular-cli-files/models/build-options.ts
View File

@ -60,7 +60,6 @@ export interface BuildOptions {
forkTypeChecker: boolean; forkTypeChecker: boolean;
profile?: boolean; profile?: boolean;
es5BrowserSupport?: boolean; es5BrowserSupport?: boolean;
experimentalImportFactories?: boolean;
main: string; main: string;
index: string; index: string;

1
packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/typescript.ts
View File

@ -91,7 +91,6 @@ function _createAotPlugin(
contextElementDependencyConstructor: require('webpack/lib/dependencies/ContextElementDependency'), contextElementDependencyConstructor: require('webpack/lib/dependencies/ContextElementDependency'),
logger: wco.logger, logger: wco.logger,
directTemplateLoading: true, directTemplateLoading: true,
importFactories: buildOptions.experimentalImportFactories,
...options, ...options,
}; };

5
packages/angular_devkit/build_angular/src/browser/schema.json
View File

@ -316,11 +316,6 @@
"default": false, "default": false,
"x-deprecated": true "x-deprecated": true
}, },
"experimentalImportFactories": {
"description": "**EXPERIMENTAL** Transform import statements for lazy routes to import factories when using View Engine. Should only be used when switching back and forth between View Engine and Ivy. See https://angular.io/guide/ivy for usage information.",
"type": "boolean",
"default": false
},
"webWorkerTsConfig": { "webWorkerTsConfig": {
"type": "string", "type": "string",
"description": "TypeScript configuration for Web Worker modules." "description": "TypeScript configuration for Web Worker modules."

7
tests/legacy-cli/e2e/tests/build/lazy-load-syntax.ts
View File

@ -89,13 +89,6 @@ export default async function () {
await ng('e2e', '--prod'); await ng('e2e', '--prod');
// Test `import()` style lazy load. // Test `import()` style lazy load.
if (!ivyProject) {
await updateJsonFile('angular.json', json => {
// Add the experimental flag to import factories in View Engine.
const buildTarget = json['projects'][projectName]['architect']['build'];
buildTarget['options']['experimentalImportFactories'] = true;
});
}
// Both Ivy and View Engine should support it. // Both Ivy and View Engine should support it.
await replaceLoadChildren(`() => import('./lazy/lazy.module').then(m => m.LazyModule)`); await replaceLoadChildren(`() => import('./lazy/lazy.module').then(m => m.LazyModule)`);