Graham/angular-cli
1
0
Fork 0
mirror of https://github.com/angular/angular-cli.git synced 2025-05-23 07:19:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(@angular/cli): remove no-bin-links during npm/yarn install

Browse Source 
Previously we passed `--no-bin-links` because we used to install packages globally in some cases. But now this is no longer needed as we should now have permissions to generate "local" bin links even during a temp installations as these  will no longer generate bin links in the global context.

Fixes #16133
This commit is contained in:
Alan Agius 2019-11-11 09:53:17 +01:00 committed by Minko Gechev
parent 150d0f6d6e
commit 08c3959ee4
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/angular/cli/tasks/install-package.ts
View File

@ -21,7 +21,6 @@ interface PackageManagerOptions {
saveDev: string; saveDev: string;
install: string; install: string;
prefix: string; prefix: string;
noBinLinks: string;
noLockfile: string; noLockfile: string;
} }
@ -39,7 +38,6 @@ export function installPackage(
packageManagerArgs.install, packageManagerArgs.install,
packageName, packageName,
packageManagerArgs.silent, packageManagerArgs.silent,
packageManagerArgs.noBinLinks,
]; ];
logger.info(colors.green(`Installing packages for tooling via ${packageManager}.`)); logger.info(colors.green(`Installing packages for tooling via ${packageManager}.`));
@ -153,7 +151,6 @@ function getPackageManagerArguments(packageManager: PackageManager): PackageMana
saveDev: '--dev', saveDev: '--dev',
install: 'add', install: 'add',
prefix: '--modules-folder', prefix: '--modules-folder',
noBinLinks: '--no-bin-links',
noLockfile: '--no-lockfile', noLockfile: '--no-lockfile',
} }
: { : {
@ -161,7 +158,6 @@ function getPackageManagerArguments(packageManager: PackageManager): PackageMana
saveDev: '--save-dev', saveDev: '--save-dev',
install: 'install', install: 'install',
prefix: '--prefix', prefix: '--prefix',
noBinLinks: '--no-bin-links',
noLockfile: '--no-package-lock', noLockfile: '--no-package-lock',
}; };
} }